Skip to content

fix: add row-level locking to RemittanceRepository.upsert #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroldwonder merged 1 commit into from
Jun 1, 2026
Merged

fix: add row-level locking to RemittanceRepository.upsert #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 53 additions & 39 deletions backend/src/repositories/RemittanceRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,44 +61,58 @@ export class RemittanceRepository {
}

async upsert(record: Omit<TransactionRecord, 'id' | 'created_at' | 'updated_at'>): Promise<void> {
await this.pool.query(
`INSERT INTO transactions
(transaction_id, anchor_id, kind, status, status_eta,
amount_in, amount_out, amount_fee, asset_code,
stellar_transaction_id, external_transaction_id,
kyc_status, kyc_fields, kyc_rejection_reason, message, memo, sender_address, correlation_id)
VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18)
ON CONFLICT (transaction_id) DO UPDATE SET
status = EXCLUDED.status,
amount_in = COALESCE(EXCLUDED.amount_in, transactions.amount_in),
amount_out = COALESCE(EXCLUDED.amount_out, transactions.amount_out),
amount_fee = COALESCE(EXCLUDED.amount_fee, transactions.amount_fee),
stellar_transaction_id = COALESCE(EXCLUDED.stellar_transaction_id, transactions.stellar_transaction_id),
external_transaction_id = COALESCE(EXCLUDED.external_transaction_id, transactions.external_transaction_id),
kyc_status = COALESCE(EXCLUDED.kyc_status, transactions.kyc_status),
message = COALESCE(EXCLUDED.message, transactions.message),
correlation_id = COALESCE(EXCLUDED.correlation_id, transactions.correlation_id),
updated_at = NOW()`,
[
record.transaction_id,
record.anchor_id ?? null,
record.kind ?? null,
record.status ?? null,
record.status_eta ?? null,
record.amount_in ?? null,
record.amount_out ?? null,
record.amount_fee ?? null,
record.asset_code ?? null,
record.stellar_transaction_id ?? null,
record.external_transaction_id ?? null,
record.kyc_status ?? null,
record.kyc_fields ? JSON.stringify(record.kyc_fields) : null,
record.kyc_rejection_reason ?? null,
record.message ?? null,
record.memo ?? null,
record.sender_address ?? null,
record.correlation_id ?? null,
]
);
const client = await this.pool.connect();
try {
await client.query('BEGIN');
await client.query(
`SELECT id FROM transactions WHERE transaction_id = $1 FOR UPDATE`,
[record.transaction_id]
);
await client.query(
`INSERT INTO transactions
(transaction_id, anchor_id, kind, status, status_eta,
amount_in, amount_out, amount_fee, asset_code,
stellar_transaction_id, external_transaction_id,
kyc_status, kyc_fields, kyc_rejection_reason, message, memo, sender_address, correlation_id)
VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18)
ON CONFLICT (transaction_id) DO UPDATE SET
status = EXCLUDED.status,
amount_in = COALESCE(EXCLUDED.amount_in, transactions.amount_in),
amount_out = COALESCE(EXCLUDED.amount_out, transactions.amount_out),
amount_fee = COALESCE(EXCLUDED.amount_fee, transactions.amount_fee),
stellar_transaction_id = COALESCE(EXCLUDED.stellar_transaction_id, transactions.stellar_transaction_id),
external_transaction_id = COALESCE(EXCLUDED.external_transaction_id, transactions.external_transaction_id),
kyc_status = COALESCE(EXCLUDED.kyc_status, transactions.kyc_status),
message = COALESCE(EXCLUDED.message, transactions.message),
correlation_id = COALESCE(EXCLUDED.correlation_id, transactions.correlation_id),
updated_at = NOW()`,
[
record.transaction_id,
record.anchor_id ?? null,
record.kind ?? null,
record.status ?? null,
record.status_eta ?? null,
record.amount_in ?? null,
record.amount_out ?? null,
record.amount_fee ?? null,
record.asset_code ?? null,
record.stellar_transaction_id ?? null,
record.external_transaction_id ?? null,
record.kyc_status ?? null,
record.kyc_fields ? JSON.stringify(record.kyc_fields) : null,
record.kyc_rejection_reason ?? null,
record.message ?? null,
record.memo ?? null,
record.sender_address ?? null,
record.correlation_id ?? null,
]
);
await client.query('COMMIT');
} catch (err) {
await client.query('ROLLBACK');
throw err;
} finally {
client.release();
}
}
}