Skip to content

fix: Require 2FA confirmation for simulateUpgrade endpoint#751

Merged
Haroldwonder merged 1 commit into
Haroldwonder:mainfrom
obacollins-lab:fix/690-simulate-upgrade-2fa
Jun 1, 2026
Merged

fix: Require 2FA confirmation for simulateUpgrade endpoint#751
Haroldwonder merged 1 commit into
Haroldwonder:mainfrom
obacollins-lab:fix/690-simulate-upgrade-2fa

Conversation

@obacollins-lab
Copy link
Copy Markdown

  • Add confirmation_token requirement to POST /api/admin/simulate-upgrade
  • Verify token using AdminConfirmationService before executing simulation
  • Prevent unauthorized upgrade simulations with compromised API key alone
  • Consistent with other high-risk admin operations
  • Update OpenAPI documentation to reflect 2FA requirement
  • Return 401 for invalid or expired confirmation tokens

closes #690

…ndpoint

- Add confirmation_token requirement to POST /api/admin/simulate-upgrade
- Verify token using AdminConfirmationService before executing simulation
- Prevent unauthorized upgrade simulations with compromised API key alone
- Consistent with other high-risk admin operations
- Update OpenAPI documentation to reflect 2FA requirement
- Return 401 for invalid or expired confirmation tokens
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

Someone is attempting to deploy a commit to the Harold's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@obacollins-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Haroldwonder Haroldwonder merged commit 7695815 into Haroldwonder:main Jun 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api/src/routes/admin.ts simulateUpgrade endpoint does not require 2FA confirmation

2 participants