Skip to content

fix: Use timing-safe comparison for API key validation #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroldwonder merged 1 commit into from
Jun 1, 2026
Merged

fix: Use timing-safe comparison for API key validation #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion api/src/routes/anchors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Router, Request, Response } from 'express';
import { timingSafeEqual } from 'crypto';
import { AnchorProvider, AnchorListResponse, AnchorDetailResponse } from '../types/anchor';
import { ErrorResponse } from '../types';
import {
Expand Down Expand Up @@ -88,7 +89,22 @@ function requireAdminApiKey(adminApiKey?: string) {
}

const requestApiKey = req.header('x-api-key');
if (!requestApiKey || requestApiKey !== adminApiKey) {
if (!requestApiKey) {
return sendError(res, 401, 'Unauthorized', 'UNAUTHORIZED');
}

// Use timing-safe comparison to prevent timing attacks
try {
const keysMatch = timingSafeEqual(
Buffer.from(requestApiKey),
Buffer.from(adminApiKey),
);
if (!keysMatch) {
return sendError(res, 401, 'Unauthorized', 'UNAUTHORIZED');
}
} catch {
// timingSafeEqual throws if buffers are different lengths
// This is expected for invalid keys, treat as unauthorized
return sendError(res, 401, 'Unauthorized', 'UNAUTHORIZED');
}

Expand Down