fix(frontend): clamp page URL param to valid range#758
Open
mathewsap45 wants to merge 1 commit into
Open
Conversation
getPageFromSearchParams now accepts a maxPage argument and clamps the parsed value to [1, maxPage], preventing ?page=999999999 from requesting a non-existent page. handlePageChange also clamps to totalPages.
|
@mathewsap45 is attempting to deploy a commit to the Harold's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@mathewsap45 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #660
Adds an upper bound check to
getPageFromSearchParamsinfrontend/src/components/TransactionHistory.tsxand clamps the page inhandlePageChange.Problem
?page=999999999would be parsed and used as-is, requesting a non-existent page with no clamping.Fix
getPageFromSearchParams(params, maxPage)now accepts an optionalmaxPageargument (defaults toNumber.MAX_SAFE_INTEGER) and returnsMath.min(parsedPage, maxPage)handlePageChangeclampsnewPageto[1, totalPages]before applying it