Repository navigation
fix: use ASSISTANT_NAME in overlay UI - #14
Harshbansal8705 merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The direct-run demo still displays a hardcoded assistant name.
Review effort: Lite
Findings: None
What changed in this PR
Updates overlay UI text to use the configured assistant name instead of hardcoded “Jasper”.
Changes:
- Uses
config.ASSISTANT_NAMEfor the window title, response prefix, and active status.
| File | Summary | Finding |
|---|---|---|
src/ui/overlay.py |
Uses the configured assistant name for overlay labels. | Direct-run demo still hardcodes “Jasper”; update it to use config.ASSISTANT_NAME or remove it. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Resolved. Updated the remaining user-facing assistant name reference to use config.ASSISTANT_NAME and verified there are no remaining hardcoded "Jasper" strings in src/ui/overlay.py. Validation:
|
|
Hi @Harshbansal8705, |
|
@sivaadithya25, OSCI'26 will resume from October again, so we're currently not merging any PRs until 30th September. |
|
Hi @Harshbansal8705, Thank you for the update and for letting me know about the OSCI26 timeline. I completely understand. Thank you as well for allowing me to continue working on other issues in the meantime. I'm grateful for the opportunity to contribute to the project and learn from the process. I'll keep exploring open issues and contributing where I can while waiting for the program to resume in October. Looking forward to the review of PR #14 when merges reopen. Thanks again for your guidance and support! 😊 |
|
Hi @Harshbansal8705, I'd like to work on fixing the Ruff BLE001 lint violations reported in the workflow checks. Could you please assign this issue to me? Thanks! |
|
Always link the issue you're talking about. If it's not there, create a new one. And regarding the issue related to ruff, I'm currently working on updating the setup and linting of the project. Any issue related to that should be resolved by then. |
|
Hi @Harshbansal8705, Understood, thanks for the clarification. I'll look for other issues to contribute to and will make sure to link the relevant issue when requesting assignment. Thank you for the guidance and for allowing me to continue contributing to the project. I really appreciate it. Thanks! |
|
Hi @Harshbansal8705, Hope you're doing well! Now that October has started and OSCI'26 is resuming, I wanted to kindly follow up on PR (#14) when you have a moment. I noticed there are some merge conflicts in src/ui/overlay.py and a failing lint check. Since you mentioned you were working on updating the setup and linting of the project, please let me know if I should go ahead and resolve the conflict/lint issues from my end, or if I should wait for your updates. Thank you! 😊 |
|
Yes, go ahead |
|
Hi @Harshbansal8705, |
bb15096 to
11c0f2b
Compare
|
Hi @Harshbansal8705, |
| except Exception as e: | ||
| logger.error(f"Error during recording: {e}") | ||
| except Exception as exc: # noqa: BLE001 - report setup failures before exiting | ||
| logger.error("Error during recording: %s", exc) |
There was a problem hiding this comment.
Is this change really required?
| except Exception as e: | ||
| logger.error(f"Error processing audio: {e}") | ||
| except Exception as exc: # noqa: BLE001 - contain failures from the audio/API boundary | ||
| logger.error("Error processing audio: %s", exc) |
| except Exception as e: | ||
| logger.error(f"Error processing query: {e}") | ||
| except Exception as exc: # noqa: BLE001 - keep the assistant responsive at the application boundary | ||
| logger.error("Error processing query: %s", exc) |
There was a problem hiding this comment.
Please remove these changes...
|
You should always run |
|
Hi @Harshbansal8705, |
9d2f7d7 to
0049cbd
Compare
|
Hi @Harshbansal8705 ! |
|
@sivaadithya25 Please take a look at your changes before asking for review. There are no changes in |
|
Hi @Harshbansal8705,
|
0049cbd to
26954b3
Compare
|
Hi @Harshbansal8705, thanks for pointing that out. I reviewed #3 and #5 again and updated the PR to include only the required changes in src/ui/overlay.py and src/config.py. I also removed the unrelated exception-handling changes. The PR is now ready for re-review. Thank you! |
There was a problem hiding this comment.
Please update this one too.
There was a problem hiding this comment.
Hi @Harshbansal8705,
I've addressed the latest feedback by adding the required config.py change for the transcription prompt and removing the unrelated exception-handling changes. I also updated the remaining hardcoded demo "Jasper" reference in overlay.py.
The branch now contains only the intended config.py and overlay.py changes, and all validation checks pass.
Ready for re-review. Thank you!
26954b3 to
140fd7c
Compare
|
Hi @Harshbansal8705, |
|
Hi @Harshbansal8705, |
|
Hi @Harshbansal8705, Hope you're doing well! Now that October has started and OSCI'26 is resuming, I wanted to kindly follow up on PR (#14) when you have a moment. I noticed there are some merge conflicts in src/ui/overlay.py and a failing lint check. Since you mentioned you were working on updating the setup and linting of the project, please let me know if I should go ahead and resolve the conflict/lint issues from my end, or if I should wait for your updates. Thank you! 😊 |
|
Thanks @sivaadithya25 |
|
Thank you so much, @Harshbansal8705! 🙌 |
Description
Fixes #3
Fixes #5
Replaced hardcoded references to "Jasper" with
config.ASSISTANT_NAMEto ensure personalization settings are respected throughout the application.Type of Change
Changes Made
Issue #3 - Overlay UI
config.ASSISTANT_NAMEconfig.ASSISTANT_NAMEconfig.ASSISTANT_NAMEIssue #5 - Transcription Prompt
config.ASSISTANT_NAMEHow Has This Been Tested?
Validation: