Fixed Up Arrow Jump Bug#178
Open
videozane wants to merge 1 commit into
Open
Conversation
Fixed bug where you would just jump forever.
DonovanTyler
approved these changes
Jun 10, 2022
DonovanTyler
left a comment
DonovanTyler
left a comment
There was a problem hiding this comment.
While holding the jump arrow still causes the player to jump repeatedly (unlike holding Z), the bug of jumping forever once the up arrow is pressed seems to have been fixed. All this being said, I tried recreating the bug in main and I couldn't do so (though in this version, the up arrow appears to have the functionality of the Z key in main rather than the up arrow in the previous version). As such, though I am approving this pull request since the code is functional, I suggest more reviews be done before actually going through with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug where you would just jump forever, I believe caused by Micah (sorry playa)
To recreate in main just press up arrow once it'll keep jumping