feat: implement ESOL and ClinTox evaluation datasets - #2
Merged
Conversation
jsture
requested changes
May 13, 2026
jsture
left a comment
jsture
left a comment
Contributor
There was a problem hiding this comment.
Unstage irrelevant formatting changed files
| @@ -36,12 +36,8 @@ def file_sha256(path: Path) -> str: | |||
|
|
|||
| def main() -> None: | |||
Contributor
There was a problem hiding this comment.
There's no need to commit files with formatting changes that you aren't make active changes to. Just unstage them and keep the files you're actively contributing.
Contributor
Author
There was a problem hiding this comment.
done, but then the CI / Lint test is still failing because the CI is currently flagging other existing files in the repo
SaraAngelucci
force-pushed
the
feature/add-esol-clintox-datasets
branch
from
May 13, 2026 21:10
644a47e to
77bb07b
Compare
SaraAngelucci
force-pushed
the
feature/add-esol-clintox-datasets
branch
from
May 13, 2026 21:12
77bb07b to
193a9bf
Compare
jsture
approved these changes
May 15, 2026
jsture
left a comment
jsture
left a comment
Contributor
There was a problem hiding this comment.
LGTM! As long as tests pass. I'll fix the Lint some other time.
Merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the ESOL (regression) and ClinTox (classification) datasets. I've set up the loaders in contributed_datasets.py (to handle the missing label drops and 0/1 coercion for ClinTox). Tests are passing locally