Skip to content

Bump aidbox-ts-sdk: fix extension on nested elements - #124

Merged
aleksandrkislitsyn merged 1 commit into
masterfrom
bump/aidbox-ts-sdk-8121-extension-fix
Aug 5, 2026
Merged

Bump aidbox-ts-sdk: fix extension on nested elements#124
aleksandrkislitsyn merged 1 commit into
masterfrom
bump/aidbox-ts-sdk-8121-extension-fix

Conversation

@aleksandrkislitsyn

Copy link
Copy Markdown
Contributor

Bumps the aidbox-ts-sdk submodule 484b967 → bf86fae (current sdk master) to pick up aidbox-ts-sdk#150.

What it fixes

The FHIR editor falsely flagged a valid extension on nested elements as an Unknown property, and omitted it from autocomplete — e.g. QuestionnaireResponse.item[].extension, Patient.contact[].extension. #150 fixes resolveElements to include the universal element properties (id/extension, plus modifierExtension on BackboneElements/resources) that a StructureDefinition differential doesn't repeat for nested elements.

Fixes HealthSamurai/sansara#8121.

Note on the pointer change

The previous pin 484b967 ("indent with two spaces") was an sdk commit that was never merged to sdk master — it targeted the old indentUnit/insertTab Tab-handling code, which sdk master has since replaced with computeYamlNewlineIndent. So this bump moves forward to sdk master's current indentation handling; the orphaned commit is superseded, not a live feature being dropped. (Worth a quick confirm that 2-space editor indentation still behaves as expected on master — independent of this fix.)

🤖 Generated with Claude Code

@aleksandrkislitsyn

Copy link
Copy Markdown
Contributor Author

⚠️ Hold / needs re-pointing.

This bump targets sdk master (bf86fae), but investigation showed aidbox-ui actually tracks the sdk development branch (current pin 484b967 is development's tip, ~296 commits ahead of master). Bumping to master regresses APIs aidbox-ui depends on (reverseIcon/contentStyle on TableHead, CodeEditor props) — hence the typecheck failure here.

The #8121 fix has been re-applied onto development in aidbox-ts-sdk#151. Once that merges, I'll re-point this PR to development's new tip (fix + all current APIs), which will make typecheck pass.

Bumps aidbox-ts-sdk 484b967 -> 6a29dc0 (development tip), picking up
aidbox-ts-sdk#151: fhir-autocomplete resolveElements now includes
id/extension/modifierExtension for nested backbone/complex elements, fixing
the editor falsely flagging a valid `extension` on e.g.
QuestionnaireResponse.item / Patient.contact and omitting it from
autocomplete.

Fixes HealthSamurai/sansara#8121

Co-Authored-By: Aleksandr Kislitsyn <aleksandr.kislitsyn@gmail.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aleksandrkislitsyn
aleksandrkislitsyn force-pushed the bump/aidbox-ts-sdk-8121-extension-fix branch from 1bf3dd7 to 74078a0 Compare August 5, 2026 12:30
@aleksandrkislitsyn

Copy link
Copy Markdown
Contributor Author

Re-pointed: now bumps aidbox-ts-sdk 484b967 → 6a29dc0 (development tip, which merged aidbox-ts-sdk#151). This is a clean forward bump from master's current pin — it adds the #8121 fix while keeping all the APIs aidbox-ui depends on, so the earlier typecheck regression is resolved.

@aleksandrkislitsyn
aleksandrkislitsyn merged commit 4d97d79 into master Aug 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant