Fix switching back to previous locale after switching based on hintLocales#1798
Merged
Helium314 merged 2 commits intoHeliBorg:mainfrom Jul 28, 2025
Merged
Fix switching back to previous locale after switching based on hintLocales#1798Helium314 merged 2 commits intoHeliBorg:mainfrom
hintLocales#1798Helium314 merged 2 commits intoHeliBorg:mainfrom
Conversation
Collaborator
|
Thanks for finding this, how did you notice? Can you tell where the multiple instances are coming from? Might be better to fix it there, because a unwanted failing equals check could also cause problems in other places. |
Contributor
Author
While testing emoji search
Looks like they come from the async parcel-ization. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there are multiple instances of the same
InputMethodSubtype, which caused this condition to incorrectly hold true.Possibly related to #596 (comment).