Skip to content

Fix switching back to previous locale after switching based on hintLocales#1798

Merged
Helium314 merged 2 commits intoHeliBorg:mainfrom
eranl:locale-switch-back
Jul 28, 2025
Merged

Fix switching back to previous locale after switching based on hintLocales#1798
Helium314 merged 2 commits intoHeliBorg:mainfrom
eranl:locale-switch-back

Conversation

@eranl
Copy link
Contributor

@eranl eranl commented Jul 18, 2025

Turns out there are multiple instances of the same InputMethodSubtype, which caused this condition to incorrectly hold true.

Possibly related to #596 (comment).

@Helium314
Copy link
Collaborator

Thanks for finding this, how did you notice?

Can you tell where the multiple instances are coming from? Might be better to fix it there, because a unwanted failing equals check could also cause problems in other places.
My first guess would be it's related to custom subtypes that get created from SettingsSubtype.

@eranl
Copy link
Contributor Author

eranl commented Jul 27, 2025

how did you notice?

While testing emoji search hintLocales.

Can you tell where the multiple instances are coming from?

Looks like they come from the async parcel-ization.

@eranl
Copy link
Contributor Author

eranl commented Jul 27, 2025

While testing #1816, I found another failure mode. See fe52309.

@Helium314 Helium314 merged commit 40480bf into HeliBorg:main Jul 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants