Skip to content

Make deleting a phantom space a separate backspace press #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eranl wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Make deleting a phantom space a separate backspace press #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f3ee48
Make deleting a phantom space a separate backspace press
eranl Jul 19, 2025
d23a42b
Fix failing test
eranl Jul 19, 2025
14cee73
Fix glide typing, restart suggestions
eranl Jul 20, 2025
f1c2ced
Cleanup
eranl Jul 20, 2025
74472f1
Batch input
eranl Jul 27, 2025
7f74fe1
Fix failing test
eranl Jul 27, 2025
dede4b6
Merge branch 'refs/heads/main' into backspace-phantom
eranl Nov 14, 2025
53d0ce0
Fix main merge
eranl Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/main/java/helium314/keyboard/latin/inputlogic/InputLogic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,9 @@ private void handleBackspaceEvent(final Event event, final InputTransaction inpu
}
if (mWordComposer.isComposingWord()) {
if (mWordComposer.isBatchMode()) {
if (SpaceState.PHANTOM == inputTransaction.getSpaceState()) {
return;
}
final String rejectedSuggestion = mWordComposer.getTypedWord();
mWordComposer.reset();
mWordComposer.setRejectedBatchModeSuggestion(rejectedSuggestion);
Expand Down Expand Up @@ -1305,6 +1308,9 @@ private void handleBackspaceEvent(final Event event, final InputTransaction inpu
// Likewise
return;
}
} else if (SpaceState.PHANTOM == inputTransaction.getSpaceState()) {
restartSuggestionsOnWordTouchedByCursor(inputTransaction.getSettingsValues(), currentKeyboardScript);
return;
}

boolean hasUnlearnedWordBeingDeleted = false;
Expand Down
3 changes: 2 additions & 1 deletion app/src/test/java/helium314/keyboard/latin/InputLogicTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,8 @@ class InputLogicTest {
reset()
glideTypingInput("hello")
assertEquals("hello", text)
functionalKeyPress(KeyCode.DELETE)
functionalKeyPress(KeyCode.DELETE) // delete phantom space
functionalKeyPress(KeyCode.DELETE) // delete word
assertEquals("", text)

// todo: now we want some way to disable delete-all on backspace, either per setting or something else
Expand Down
Loading