BufferSubData overflow with sky geometry - #1787
Merged
Merged
Conversation
…em but when the property still exists it causes it to try to clear memory outside the bounds of the GPU. adds release guard to never try to upload outside of range as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reproduced reloading Eviternity MAP29 after the initial structures fall at the start. The SkyGeometry was never cleared from the side which caused the SkyGeometryManager to try to clear on stale references. On map reloads everything is assumed to be cleared so the StaticCacheGeometryRenderer will try to add everything new while the SkyGeometryManager would see the reference and end up using an out of bound index to try to clear.
Updates to InitBlockUnaligned to match StaticCacheGeometryRenderer for clearing vertices. It was also previously missing zero on the PrevZ.
This also adds a release guard to never upload out of range in addition to the debug assert.