Memoize upload family observer atom in CreatePost - #20
Merged
Merged
Conversation
CreatePostForm created a brand-new derived jotai atom (and a new array) on every render instead of memoizing it, which put the component into a continuous render loop. The churn from that loop raced with the browser's native focus/selection handling: clicking into the editor or pressing Home/End no longer reliably moved the caret (new text kept landing at the end instead), while Slate's own synchronously-handled arrow keys were unaffected. Memoizing the derived atom on selectedFiles stops the loop and fixes the focus/ cursor behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTvu9CJynDZnCKonytghnF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrapped the
createUploadFamilyObserverAtomcall inuseMemowithselectedFilesas a dependency in theCreatePostFormcomponent. This prevents unnecessary recreation of the atom on every render, which could cause performance issues and unintended side effects when the atom is used withuseAtomValue.The atom is now only recreated when
selectedFilesactually changes, ensuring stable atom identity across renders and improving performance.Checklist:
https://claude.ai/code/session_01PTvu9CJynDZnCKonytghnF