Refactor CreatePost to use spaces with posts rooms - #22
Open
KallynGowdy wants to merge 2 commits into
Open
KallynGowdy wants to merge 2 commits into
KallynGowdy wants to merge 2 commits into
Conversation
The Share dialog's room picker now lists spaces, restricted to those containing a room whose name ends with "-posts". Posts (text and attachments) go to the first such room found in the selected space. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xskt9Qyd28qFo7vDvM5ohZ
Tells the user whether the selected space's "-posts" room is public
("This will be shared publicly") or private before they post.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xskt9Qyd28qFo7vDvM5ohZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
CreatePostFormcomponent to work with spaces and their associated posts rooms, rather than directly with feed room IDs. This change introduces a new hookuseSpacesWithPostsRoomthat identifies spaces containing a room whose name ends with "-posts" and pairs each space with its posts room ID.Key changes:
useFeedRoomsimport touseSpacesWithPostsRoomand updated its implementation to returnSpaceWithPostsRoom[]objects containing bothspaceIdandpostsRoomIdCreatePostFormto track both the selected space and its associated posts room separatelyroomIdtospaceIdfor the dropdown selector, withpostsRoomIdderived from the selected spacepostsRoomIdinstead ofroomIdhandleRoomSelect→handleSpaceSelect,feedRooms→spaces, etc.)This refactoring maintains the same user-facing functionality while improving the semantic clarity of the code by distinguishing between the space (where the user selects from) and the posts room (where messages are actually sent).
Fixes #
Checklist:
https://claude.ai/code/session_01Xskt9Qyd28qFo7vDvM5ohZ