Repository navigation
Fail startup closed when a valve faults after ignition - #289
Merged
Merged
Conversation
Combustion verification and throttle-up ignored actuator status after the spark pulse. A faulted valve stayed at its last open command, and a Ready operating pressure could declare the engine running. Running does not command those valves again. The same Ready gate used before each open now applies again before combustion, before throttle-up can finish, and when a valve faults during the spark pulse. Co-authored-by: Pejman Haghighatnia <pejmantheory@users.noreply.github.com>
The running state used to return without reading actuator status, so a valve that faulted after the sequence finished stayed at its last open command until stop or abort. A pass that is still running now uses the same Ready gate. Ready actuators are left where they are. Any other status fail-closes and the closed loop retries the shutdown. Co-authored-by: Pejman Haghighatnia <pejmantheory@users.noreply.github.com>
pejmantheory
marked this pull request as ready for review
October 24, 2026 18:30
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combustion verification and throttle-up did not read actuator status after the ignition pre-check. Fuel and oxidizer are already open in those states. A valve that reported Fault, Error, Disabled, Unknown, Moving, or AtPosition stayed at its last open command. A Ready operating chamber pressure then declared the engine running, and the running state does not command those valves again.
The same Ready gate used before each open now runs again after the spark pulse, during combustion verification, and before throttle-up can finish or keep ramping. A valve that is not Ready fail-closes on that pass. An abort that already won is left as abort. A Ready operating pressure with every actuator still Ready still declares the engine running and does not command the valves.
Related issues
None. Found in the daily safety scan.
Type of change
How to test
dotnet test Tests/HelloblueGK.Tests.csproj -c Release --filter FullyQualifiedName~StartupSequenceControllerTestsChecklist
dotnet buildsucceeds locally (or I ran the equivalent CI steps)dotnet test Tests/HelloblueGK.Tests.csprojpasses (or tests are not applicable).envfilesCertification/unless the issue asked for itScreenshots / logs (optional)
Release suite: 1604 passed, 0 failed. Startup sequence filter: 99 passed.
dotnet list package --vulnerable --include-transitivereported no vulnerable packages for HelloblueGK, HelloblueGK.WebAPI, and HelloblueGK.Tests. That is a dependency audit of those three projects.Note
High Risk
Changes engine startup safety logic while propellant valves may be open; incorrect gating could spuriously abort or miss a faulted valve.
Overview
Extends actuator Ready gating so propellant valves cannot stay open while the sequence advances—or after it reaches Running—when fuel, oxidizer, or igniter is no longer
Ready.After the igniter spark pulse, the sequence re-runs
RequireStartupActuatorsReadyAsyncbefore entering combustion verification. The same check runs at the start and end of combustion verification (including after sensor reads), before and after throttle-up pressure logic, and at the end of the throttle ramp delay instead of only callingContinueSequenceAsync. The control loop no longer treats Running as a no-op: each pass verifies actuators are still Ready and fail-closes if not.Unit tests cover faults during spark, combustion wait, throttle-up, and while Running, plus the happy path where Ready actuators and operating pressure still reach Running without extra valve commands.
Reviewed by Cursor Bugbot for commit 9942b67. Bugbot is set up for automated code reviews on this repo. Configure here.