You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add req-6, recording BleuJS and NVIDIA failures followed by a successful OpenAI fallback.
Recalculate the expected routing success and fallback rates across all six fixtures.
Manual counts: solved 5 of 6, fallback 3 of 6.
Verification
Passed locally:
pnpm run format:check
pnpm run lint
pnpm run type-check
pnpm run test:eval (4/4 tests)
pnpm run eval (6/6 benchmarks)
git diff --check
Testing caveat: The full pnpm run check did not completely pass on Windows. Three tests in tests/unit/gitSha.test.ts failed due to a Git pathspec quoting issue in the existing src/evals/gitSha.ts. No unrelated code was changed. Please verify the GitHub Actions results for the pull request before considering the full suite passed.
Hi @AvadhKalathiya, welcome, and thanks for your first contribution to BleuJS Reasoning Lab!
This is a nice, focused change. req-6 adds the missing "third provider succeeds" fallback case, and I checked the counts by hand: 5 of 6 solved, 3 of 6 via fallback. Writing the expected values as 5 / 6 and 3 / 6 is a good call, since the runner compares with exact equality. I also ran pnpm run check on Linux and everything passes, including the gitSha tests, so the failures you saw look Windows-only (feel free to open a separate issue for that).
One small request: src/evals/results/latest.json still shows the old routing rates (0.80 / 0.40). Could you run pnpm run eval and commit the regenerated file so the published results match (0.83 / 0.50)? Or leave it and I'll regenerate it after merging, just let me know.
I've approved the CI run for your fork. Once it's green, this is good to merge. Thanks again!
Hi @pejmantheory, thanks for reviewing the PR and approving the CI run!
I tried running pnpm run eval locally. The benchmarks passed 6/6, and the routing rates correctly show 0.83 success and 0.50 fallback. However, the existing Windows-specific Git pathspec issue caused getGitSha() to return null, so I reverted the generated results file rather than risk committing incorrect provenance.
Since I don't have a working Linux/WSL environment locally, I'll leave latest.json unchanged as you suggested. Please feel free to regenerate it after merging.
No additional commit or push was made. Thanks again for your guidance and support!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
req-6, recording BleuJS and NVIDIA failures followed by a successful OpenAI fallback.Manual counts: solved 5 of 6, fallback 3 of 6.
Verification
Passed locally:
pnpm run format:checkpnpm run lintpnpm run type-checkpnpm run test:eval(4/4 tests)pnpm run eval(6/6 benchmarks)git diff --checkTesting caveat: The full
pnpm run checkdid not completely pass on Windows. Three tests intests/unit/gitSha.test.tsfailed due to a Git pathspec quoting issue in the existingsrc/evals/gitSha.ts. No unrelated code was changed. Please verify the GitHub Actions results for the pull request before considering the full suite passed.Closes #34