Skip to content

test: add OpenAI fallback routing fixture - #89

Merged
pejmantheory merged 1 commit into
HelloblueAI:mainfrom
AvadhKalathiya:fix/issue-34-routing-fallback-fixture
Oct 24, 2026
Merged

pejmantheory merged 1 commit into
HelloblueAI:mainfrom
AvadhKalathiya:fix/issue-34-routing-fallback-fixture

Conversation

@AvadhKalathiya

Copy link
Copy Markdown
Contributor

Summary

  • Add req-6, recording BleuJS and NVIDIA failures followed by a successful OpenAI fallback.
  • Recalculate the expected routing success and fallback rates across all six fixtures.

Manual counts: solved 5 of 6, fallback 3 of 6.

Verification

Passed locally:

  • pnpm run format:check
  • pnpm run lint
  • pnpm run type-check
  • pnpm run test:eval (4/4 tests)
  • pnpm run eval (6/6 benchmarks)
  • git diff --check

Testing caveat: The full pnpm run check did not completely pass on Windows. Three tests in tests/unit/gitSha.test.ts failed due to a Git pathspec quoting issue in the existing src/evals/gitSha.ts. No unrelated code was changed. Please verify the GitHub Actions results for the pull request before considering the full suite passed.

Closes #34

@pejmantheory

pejmantheory commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Hi @AvadhKalathiya, welcome, and thanks for your first contribution to BleuJS Reasoning Lab!
This is a nice, focused change. req-6 adds the missing "third provider succeeds" fallback case, and I checked the counts by hand: 5 of 6 solved, 3 of 6 via fallback. Writing the expected values as 5 / 6 and 3 / 6 is a good call, since the runner compares with exact equality. I also ran pnpm run check on Linux and everything passes, including the gitSha tests, so the failures you saw look Windows-only (feel free to open a separate issue for that).
One small request: src/evals/results/latest.json still shows the old routing rates (0.80 / 0.40). Could you run pnpm run eval and commit the regenerated file so the published results match (0.83 / 0.50)? Or leave it and I'll regenerate it after merging, just let me know.
I've approved the CI run for your fork. Once it's green, this is good to merge. Thanks again!

@AvadhKalathiya

Copy link
Copy Markdown
Contributor Author

Hi @pejmantheory, thanks for reviewing the PR and approving the CI run!

I tried running pnpm run eval locally. The benchmarks passed 6/6, and the routing rates correctly show 0.83 success and 0.50 fallback. However, the existing Windows-specific Git pathspec issue caused getGitSha() to return null, so I reverted the generated results file rather than risk committing incorrect provenance.

Since I don't have a working Linux/WSL environment locally, I'll leave latest.json unchanged as you suggested. Please feel free to regenerate it after merging.

No additional commit or push was made. Thanks again for your guidance and support!

@pejmantheory
pejmantheory merged commit b6b50be into HelloblueAI:main Oct 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record a routing fixture for a new fallback case

2 participants