Repository navigation
fix(engine): Notion row changes are checked before the card; a flaky calendar test fixed - #258
Merged
Merged
Conversation
… before writing
The full suite saw the model pass an invented row id ("row-renew-domain" for
r14) and the owner got an approval card for a row that doesn't exist; execute
refused it after Approve. The row checks (exists, title, archived, types, old
values) now run in beforeApproval too, like the calendar move, so no card is
shown for a change that can't happen and the model is told to read again.
Tests: typecheck; test:unit 169/169 (new: invented id, wrong title, changed
value refused before a card); skills-notion-update live 3/3; k6 load/chat.js
2 VUs 20 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
The full suite failed once when the model's first googlecalendar_list_events
call failed validation (Mastra answers { error: true } as a tool.result) and
the second call ran. The test now checks the call that ran; alone it passed
3/3 before and after.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
Contributor
Author
|
Merged (CI engine green). @AncungAulia FYI: a Notion change the engine can't make (wrong row, wrong title, value changed) now comes back as a 🤖 Generated with Claude Code |
Contributor
|
Live on the hosted demo:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the full engine suite run on
mainafter today's merges: 303 tests, 301 passed, 2 failed. Both are addressed here.1. Notion: no card for a row that doesn't exist
skills-notion-updatefailed once: the model passed an invented row id (row-renew-domaininstead ofr14) and the owner got an approval card for it. It was already safe, becauseexecutere-reads the row and refused after Approve with nothing written. But a card for a non-existent row shouldn't be shown at all.The row checks (the row exists, the title matches, not archived, not a plain page, property names and types, old values) are now one function,
rowRefusal, run inbeforeApprovaland again inexecute, like the calendar move does. A refused change returnsstatus: "refused"with a message telling the model to read the database again.2. A flaky calendar test
a try-out run reads the sample calendarfailed once: the firstgooglecalendar_list_eventscall failed validation (Mastra answers{ error: true }as atool.result) and the model called again. The test now checks the call that ran. Run alone it passed 3/3.Tests
test:unit169/169. New inapps.test.ts: an invented id, a wrong title and a changed value are each refused before a card; a clear is still refused before any Composio call.skills-notion-updatelive: 3/3 runs.load/chat.js2 VUs 20 s: 30/30.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e