Repository navigation
fix(fe): a Sheet's count says it includes the header row, and next-env.d.ts back to the build's paths - #270
Merged
Merged
Conversation
The engine's count for Read a Google Sheet is the length of values, header row included (Axel, #268). The field now reads "Number of rows (with the header)"; the If's card still reads "If number of rows is more than 0", since ifTitle drops the brackets. Tests: lint, typecheck, vitest tests/builder.test.ts 41/41. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Merged with Axel's approval; lint, typecheck, |
Contributor
|
Live on the hosted demo:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Lexirieru The two small things from your note on #268.
What changed
apps/fe/next-env.d.tsgoes back to the build's paths (.next/types/…), asmainhad it before92cecb3committed the dev server's (.next/dev/types/…). I'll keep it out of future commits.countis the length ofvalues. The If's card still reads "If number of rows is more than 0", becauseifTitledrops the brackets. Notion's "Number of rows" is unchanged.apps/fe/CLAUDE.mdnotes the label.Tests (local, on
maindda8314)bun run lint,bun run typecheck: pass.bunx vitest run tests/builder.test.ts: 41/41.Ancung will try Read the calendar → If number of events > 0 on the hosted demo, as you asked.
🤖 Generated with Claude Code