Skip to content

fix(fe): a Sheet's count says it includes the header row, and next-env.d.ts back to the build's paths - #270

Merged
Lexirieru merged 2 commits into
mainfrom
fix/fe-sheets-rows-label
Nov 12, 2026
Merged

Lexirieru merged 2 commits into
mainfrom
fix/fe-sheets-rows-label

Conversation

@AncungAulia

Copy link
Copy Markdown
Contributor

@Lexirieru The two small things from your note on #268.

What changed

  • apps/fe/next-env.d.ts goes back to the build's paths (.next/types/…), as main had it before 92cecb3 committed the dev server's (.next/dev/types/…). I'll keep it out of future commits.
  • Read a Google Sheet's count reads "Number of rows (with the header)", since the engine's count is the length of values. The If's card still reads "If number of rows is more than 0", because ifTitle drops the brackets. Notion's "Number of rows" is unchanged.
  • apps/fe/CLAUDE.md notes the label.

Tests (local, on main dda8314)

  • bun run lint, bun run typecheck: pass.
  • bunx vitest run tests/builder.test.ts: 41/41.
  • Not run: integration and load tests (the FE has none).

Ancung will try Read the calendar → If number of events > 0 on the hosted demo, as you asked.

🤖 Generated with Claude Code

AncungAulia and others added 2 commits November 12, 2026 18:34
It was committed with the dev server's paths (.next/dev/types) in
92cecb3. The file is generated and the build rewrites it; this puts
back what main had before (Axel, #268).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The engine's count for Read a Google Sheet is the length of values,
header row included (Axel, #268). The field now reads "Number of
rows (with the header)"; the If's card still reads "If number of
rows is more than 0", since ifTitle drops the brackets.

Tests: lint, typecheck, vitest tests/builder.test.ts 41/41.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Lexirieru
Lexirieru merged commit 92f1894 into main Nov 12, 2026
1 check passed
@Lexirieru

Copy link
Copy Markdown
Contributor

Merged with Axel's approval; lint, typecheck, bun run test 275/275 locally. Thanks @AncungAulia.

@Lin1er

Lin1er commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Live on the hosted demo: main 92f1894 (automatic deploy after the merge).

  • Before: dda8314, and the box matched git at that revision. CI: passed: build.
  • GET /v1/health → {"ok":true,"engine":true,"revision":"92f1894"}. No rollback.
  • Rollback target: dda8314 (/opt/hellonear/release-old).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants