Skip to content

feat(fe): Check it in TEE Explorer opens the verified report, no pasting (#277) - #280

Merged
Lexirieru merged 3 commits into
mainfrom
feat/fe-tee-explorer-open
Nov 12, 2026
Merged

Lexirieru merged 3 commits into
mainfrom
feat/fe-tee-explorer-open

Conversation

@Lexirieru

Copy link
Copy Markdown
Contributor

FE part of #277, built at Axel's request so it lands before the freeze. @AncungAulia, FYI: it's your area, so please review it when you can.

What

  • In "The proof behind this reply", "Paste the quote in TEE Explorer" becomes "Check it in TEE Explorer" (ExplorerLink in ProofDialog.tsx):
    • The click opens a blank tab at once, since popup blockers only allow a tab opened in the click itself.
    • It then calls POST /runs/{runId}/proof/tee-explorer (feat(be): open the TEE Explorer report already verified, no pasting (#277) #279; the backend uploads the Intel quote) and sends the tab to the report, which already reads VERIFIED.
    • Only a https://proof.t16z.com/reports/… link is followed (explorerReportUrl).
    • On a failure the tab shows the Explorer's paste page as before, with a short line to paste the Intel quote.
  • "Copy the Intel quote" and "Copy the proof" stay.
  • chatApi.teeExplorer, the ExplorerReports type, a unit test, and apps/fe/CLAUDE.md.

Tests (local)

  • bun run lint, bun run typecheck: pass.
  • bun run test: 277/277 (new: explorerReportUrl follows only Explorer report links).
  • Chrome, local stack (FE dev, backend with feat(be): open the TEE Explorer report already verified, no pasting (#277) #279, real proof.t16z.com):
    • Path: a Payments Mind reply → Verified badge → View proof → Check it in TEE Explorer.
    • One click opened one tab, about:blank → https://proof.t16z.com/reports/9618de8a…, showing VERIFIED, "The attestation is verified and safe to use".
  • Not run: integration and load tests (the FE has none).

🤖 Generated with Claude Code

https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e

Lexirieru and others added 2 commits November 12, 2026 22:13
The proof dialog's link only opened proof.t16z.com, where pasting the whole
proof answered "The quote is invalid". The click now opens a tab at once,
asks the backend to upload the quote (POST /runs/{runId}/proof/tee-explorer,
#279) and sends the tab to the report, already VERIFIED. Only a
proof.t16z.com/reports/ link is followed; on a failure the tab shows the
paste page as before.

Tests: lint, typecheck, bun run test 277/277 (explorerReportUrl); Chrome on a
local stack against the real Explorer: one click, one tab, a VERIFIED report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
@Lexirieru

Copy link
Copy Markdown
Contributor Author

@AncungAulia could you review this one? Axel asked me to build it so it's ready before the freeze, but it's your area. CI fe/build passes. Axel merges once you approve; if you want changes, say so here and I'll make them (or push them yourself).

To try it on a local stack: open a reply's Verified badge → View proof → Check it in TEE Explorer. One tab should open and land on a VERIFIED report whose nonce matches the dialog. Needs the backend route from #279, already on main.

@AncungAulia AncungAulia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lexirieru Read it, thanks for building it. Looks good:

  • The tab opens in the click itself, so popup blockers let it through.
  • Only a https://proof.t16z.com/reports/ link is followed, and the test covers a lookalike host.
  • On a failure the tab falls back to the Explorer's paste page.

One change before it goes in:

  • The failure line reads "Couldn't check it for you. Paste the Intel quote there." The FE's system messages are formal, with no "Couldn't" (apps/fe/CLAUDE.md, Conventions). Please make it: "Could not check it automatically. Paste the Intel quote there."

Not blocking: if the blank tab itself was blocked (tab is null), the fallback window.open runs after the await, so the browser blocks that one too. That's rare, and the copy buttons still work.

With the line changed, it's approved from my side.

🤖 Generated with Claude Code

Ancung's review on #280: FE system messages say "Could not", not
"Couldn't".

Tests: lint, typecheck, bun run test 277/277.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
@Lexirieru

Copy link
Copy Markdown
Contributor Author

@AncungAulia done: the line now reads "Could not check it automatically. Paste the Intel quote there." (lint, typecheck, bun run test 277/277). You're right about the blocked-tab fallback: it opens after the await, so a browser that blocked the first tab would block it too. I've left it, since it's rare and the copy buttons still work.

@Lexirieru Ancung approves with this change, so it's ready for you to merge.

@Lexirieru
Lexirieru merged commit 2254ab5 into main Nov 12, 2026
1 check passed
@Lexirieru

Copy link
Copy Markdown
Contributor Author

Merged with Axel's approval after @AncungAulia's review; main deploys after its CI. "Check it in TEE Explorer" now opens the run's report already VERIFIED.

@Lin1er

Lin1er commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Live on the hosted demo: first in main 80b346f (automatic deploy after the merge), and now d54bed3.

  • GET /v1/health → {"ok":true,"engine":true,"revision":"d54bed3"}; be, engine, fe and landing active, no backend HTTP errors since the deploy.
  • app.hellonear.xyz, api.hellonear.xyz/v1/health and hellonear.xyz answer 200; the guest try-out e2e passed 22/22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants