Repository navigation
feat(fe): Check it in TEE Explorer opens the verified report, no pasting (#277) - #280
Conversation
The proof dialog's link only opened proof.t16z.com, where pasting the whole
proof answered "The quote is invalid". The click now opens a tab at once,
asks the backend to upload the quote (POST /runs/{runId}/proof/tee-explorer,
#279) and sends the tab to the report, already VERIFIED. Only a
proof.t16z.com/reports/ link is followed; on a failure the tab shows the
paste page as before.
Tests: lint, typecheck, bun run test 277/277 (explorerReportUrl); Chrome on a
local stack against the real Explorer: one click, one tab, a VERIFIED report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
|
@AncungAulia could you review this one? Axel asked me to build it so it's ready before the freeze, but it's your area. CI To try it on a local stack: open a reply's Verified badge → View proof → Check it in TEE Explorer. One tab should open and land on a VERIFIED report whose nonce matches the dialog. Needs the backend route from #279, already on |
AncungAulia
left a comment
There was a problem hiding this comment.
@Lexirieru Read it, thanks for building it. Looks good:
- The tab opens in the click itself, so popup blockers let it through.
- Only a
https://proof.t16z.com/reports/link is followed, and the test covers a lookalike host. - On a failure the tab falls back to the Explorer's paste page.
One change before it goes in:
- The failure line reads "Couldn't check it for you. Paste the Intel quote there." The FE's system messages are formal, with no "Couldn't" (
apps/fe/CLAUDE.md, Conventions). Please make it: "Could not check it automatically. Paste the Intel quote there."
Not blocking: if the blank tab itself was blocked (tab is null), the fallback window.open runs after the await, so the browser blocks that one too. That's rare, and the copy buttons still work.
With the line changed, it's approved from my side.
🤖 Generated with Claude Code
Ancung's review on #280: FE system messages say "Could not", not "Couldn't". Tests: lint, typecheck, bun run test 277/277. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e
|
@AncungAulia done: the line now reads "Could not check it automatically. Paste the Intel quote there." (lint, typecheck, @Lexirieru Ancung approves with this change, so it's ready for you to merge. |
|
Merged with Axel's approval after @AncungAulia's review; |
|
Live on the hosted demo: first in
|
FE part of #277, built at Axel's request so it lands before the freeze. @AncungAulia, FYI: it's your area, so please review it when you can.
What
ExplorerLinkinProofDialog.tsx):POST /runs/{runId}/proof/tee-explorer(feat(be): open the TEE Explorer report already verified, no pasting (#277) #279; the backend uploads the Intel quote) and sends the tab to the report, which already reads VERIFIED.https://proof.t16z.com/reports/…link is followed (explorerReportUrl).chatApi.teeExplorer, theExplorerReportstype, a unit test, andapps/fe/CLAUDE.md.Tests (local)
bun run lint,bun run typecheck: pass.bun run test: 277/277 (new:explorerReportUrlfollows only Explorer report links).about:blank→https://proof.t16z.com/reports/9618de8a…, showing VERIFIED, "The attestation is verified and safe to use".🤖 Generated with Claude Code
https://claude.ai/code/session_01Q5ZrzK8une3S2YyhDG746e