Repository navigation
fix(landing): Watch the demo and the footer's Demo video open the demo post on X - #335
Merged
Merged
Conversation
The button scrolled to the demo section, which has no video yet and only says "coming soon". It now opens the demo post on X in a new tab (#334). Tests: tsc --noEmit passes; next build passes. On the production build (Playwright, Chrome) at 1440x900 and 390x844, both copies of the button link to the X post with target=_blank and rel="noopener noreferrer", and a click opens a new tab while the landing stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It pointed at the demo section, which has no video yet. It now opens the same X post as the hero's "Watch the demo", in a new tab (Nabil, #334). Tests: tsc --noEmit passes; next build passes. On the production build at 1440x900 and 390x844, both footer copies link to the X post with target=_blank and rel="noopener noreferrer"; a click opens a new tab and the landing stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@Nabil-Aufa merged as #334 stays open for part 2 (the marketing video in "Two minutes with a Mind"). @Lin1er @AncungAulia for your information: only |
Contributor
|
Live on the hosted demo:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #334.
What changed
target="_blank",rel="noopener noreferrer"), instead of scrolling to the demo section, which has no video yet.apps/landing/CLAUDE.md: a note on the hero buttons and the footer link.Not in this PR: part 2 of #334 (the marketing video in "Two minutes with a Mind") waits for the video.
Tests
tsc --noEmit: passnext build: passtarget=_blankandrel="noopener noreferrer"; a click opens a new tab and the landing stays open.🤖 Generated with Claude Code