fix(ci): unblock Dependabot auto-merge (drop forbidden approval step)#323
Merged
Conversation
…step The triage job failed on every Dependabot PR at 'gh pr review --approve' with 'GitHub Actions is not permitted to approve pull requests', and because Actions bash steps run with -e, the following 'gh pr merge --auto' never executed — so nothing was ever auto-merged. main requires 0 approving reviews, so the approval was pointless anyway. Remove it and keep 'gh pr merge --auto --squash'; auto-merge now fires once the required Backend/Frontend checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every open Dependabot PR (#298–#307) has a failing
triagecheck. The auto-merge workflow's step ran:The first line fails with "GitHub Actions is not permitted to approve pull requests" (a repo/org security setting). GitHub Actions bash steps run with
set -e, so the step aborts before the merge command runs — nothing ever auto-merges.Fix
mainrequires 0 approving reviews (verified via branch protection API), so the approval is unnecessary. Drop it; keepgh pr merge --auto --squash. Auto-merge then completes once the required Backend/Frontend checks pass.Note on the current backlog
The 10 open Dependabot PRs are all npm patch/minor with green Backend+Frontend checks (only the broken
triagejob is red). They showBEHINDbecausemainrequires up-to-date branches (strict: true); Dependabot rebases keep them current going forward. This fix only re-runs on new PR events, so the existing 10 still need a nudge (rebase or manual merge) — handled separately.