Skip to content

Memory.ts#5

Open
AshwanthSai wants to merge 2 commits into
Hendrixer:mainfrom
AshwanthSai:summarization-memory-management-bug-fix
Open

Memory.ts#5
AshwanthSai wants to merge 2 commits into
Hendrixer:mainfrom
AshwanthSai:summarization-memory-management-bug-fix

Conversation

@AshwanthSai

Copy link
Copy Markdown
  • Memory management bug fix, added code to clear the first five messages; otherwise, the memory context window is not managed. This defeats the purpose of Summarization-Based Memory Management.
  • Added some comments on the getMessages function. It was extremely confusing to understand without some important context.

LLM.ts

  • Refactored runLLM code to use a dedicated LLM instance that only summarizes code.
  • Segregation of concerns + follows the runApproval check pattern.

AshwanthSai and others added 2 commits February 1, 2025 01:34
- Memory management bug fix, added code to clear the first five messages; otherwise, the memory context window is not managed. This defeats the purpose of Summarization-Based Memory Management.
- Added some comments on the getMessages function. It was extremely confusing to understand without some important context.

LLM.ts
- Refactored runLLM code to use a dedicated LLM instance that only summarizes code.
- Segregation of concerns + follows the runApproval check pattern.

@AshwanthSai AshwanthSai left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Logic Error Fixed for Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant