Claude/review v1.5.0 7r6h f#93
Merged
Merged
Conversation
Review covers: - Core algorithms (Kabsch, Hungarian, gap detection) - Shape analysis services - Coordination detection services - Reference geometries - React components and hooks - File parsers - Test coverage and runtime issues Key findings: - Build passes with minor eslint warnings - Scientific validation shows excellent SHAPE 2.1 parity - Test runtime issue identified for intensive mode tests
- Remove unused `permCount` variable in shapeCalculator.js - Add eslint-disable comment for `normalizeScaleFromOrigin` function (kept for documentation/future use as it documents important normalization behavior for pyramidal geometries) Build now compiles without warnings.
Add 60-second timeout to prevent tests from failing in CI due to computationally expensive intensive mode calculations.
Create React App doesn't support testTimeout in package.json. Move the 60-second timeout to src/setupTests.js which is the CRA-supported approach for Jest configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.