Added support for 8-card and 9-card evaluation to library interface (…#108
Open
jasonrohrer wants to merge 1 commit into
Open
Added support for 8-card and 9-card evaluation to library interface (…#108jasonrohrer wants to merge 1 commit into
jasonrohrer wants to merge 1 commit into
Conversation
…code was there, but it wasn't in header files, etc.).
Owner
|
Thanks for creating an pull request! Actually, I intented to deprecate the 8-card and 9-card evaluation methods. Do you really need to use them? If yes, we can try to bring them back. But there are a lot more work to do, especially unit tests to make sure the correctness. They can all be found in the history. I think it'd be the best to follow commit 4eec990 and see how to revert it, if we want to bring them back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…code was there, but it wasn't in header files, etc.).