ci: remove duplicate Code Quality workflow - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
.github/workflows/ci.yml, now redundant after #1 split it into two dedicated workflows.Why
ci.yml("Code Quality") defines the same two jobs as the workflows added in #1. With both present, every pull request runs three workflows and reports four status checks, with duplicate names:ci.ymlci.ymlfrontend-quality.ymlnative-quality.ymlThe duplicate
Frontend/Nativenames make it ambiguous which check branch protection would bind to, and each PR burns a redundant frontend run plus a redundant seven-minute native run.What remains afterwards
frontend-quality.ymlFrontendpull_requestnative-quality.ymlNativepull_requestThe
libasound2-dev,libgtk-3-dev,libmpv-dev, and related Linux build dependencies are not lost — they are defined in full innative-quality.yml. No behavior fromci.ymlis dropped; both job definitions were carried over verbatim in #1.Tradeoff
ci.ymlis shared with upstreamharborstremio/harbor. Deleting it in this fork means futuregit merge upstream/mainruns that touch that file will conflict. That is the cost of having exactly two checks instead of four, and it is the intended direction for this fork.