⬆️ Upgrade dependency markdown-it to v15.0.1 [SECURITY] - #830
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
renovate
Bot
force-pushed
the
renovate/npm-markdown-it-vulnerability
branch
from
September 30, 2026 04:43
9419ba7 to
9690f9e
Compare
renovate
Bot
force-pushed
the
renovate/npm-markdown-it-vulnerability
branch
from
September 30, 2026 18:44
9690f9e to
56ea94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
15.0.0→15.0.1markdown-it linkify: true has two quadratic paths, so a few hundred KB of markdown blocks the event loop for tens of seconds
GHSA-253c-mchw-3w2r
More information
Details
Summary
Two independent quadratic paths in the
linkify: truehandling. Both are in markdown-it's own code rather than in linkify-it, which stays linear on both payloads.src/rules_core/linkify.tscallsarrayReplaceAtonce per linkified text token, and that rebuilds the wholechildrenarray each time. A paragraph of N soft-broken lines is one inline token with about 2N children, so you get N rebuilds over a 2N array. Schema-less emails are what reach it. Ahttp://link gets consumed by the inline rule first and never arrives as a text token, so those stay linear.src/rules_inline/linkify.tsrunsstate.pending.match(SCHEME_RE)at every://in the source.state.pendingonly gets truncated once a link is actually produced, so an unregistered scheme leaves it growing and every://rescans the lot.Proof of concept
Clean install of 15.0.0 from npm,
new MarkdownIt({ linkify: true }).render(payload), Node 24.'a@b.co\n'.repeat(N), 34KB to 273KB'a://'.repeat(N), 20KB to 156KBDoubling the input roughly quadruples the time in both. With
linkify: falsethe same inputs run in 25 to 131ms and stay flat.Controls for the first one, all at N=20000: putting every email in a single text token (
'a@b.co ') takes 0.59s, one email per paragraph ('a@b.co\n\n') takes 0.64s, and soft-broken lines with nothing linkifiable take 42ms. So it needs many children AND many of them linkifying. For the second, replaying just theSCHEME_REcalls against the same growing prefixes with no markdown-it involved accounts for 11.7s of the 15s.Ordinary prose does it too.
'ping a@b.co ok\n'.repeat(20000)is 293KB and takes 31s.Caveat
linkifyis off by default, so this only reaches apps that turn it on.Impact
Availability only. A few hundred KB of fairly ordinary markdown pins one core for tens of seconds, and because it's quadratic it degrades quickly with size. Nothing is read, written or executed.
Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
markdown-it linkify: true has two quadratic paths, so a few hundred KB of markdown blocks the event loop for tens of seconds
GHSA-253c-mchw-3w2r
More information
Details
Summary
Two independent quadratic paths in the
linkify: truehandling. Both are in markdown-it's own code rather than in linkify-it, which stays linear on both payloads.src/rules_core/linkify.tscallsarrayReplaceAtonce per linkified text token, and that rebuilds the wholechildrenarray each time. A paragraph of N soft-broken lines is one inline token with about 2N children, so you get N rebuilds over a 2N array. Schema-less emails are what reach it. Ahttp://link gets consumed by the inline rule first and never arrives as a text token, so those stay linear.src/rules_inline/linkify.tsrunsstate.pending.match(SCHEME_RE)at every://in the source.state.pendingonly gets truncated once a link is actually produced, so an unregistered scheme leaves it growing and every://rescans the lot.Proof of concept
Clean install of 15.0.0 from npm,
new MarkdownIt({ linkify: true }).render(payload), Node 24.'a@b.co\n'.repeat(N), 34KB to 273KB'a://'.repeat(N), 20KB to 156KBDoubling the input roughly quadruples the time in both. With
linkify: falsethe same inputs run in 25 to 131ms and stay flat.Controls for the first one, all at N=20000: putting every email in a single text token (
'a@b.co ') takes 0.59s, one email per paragraph ('a@b.co\n\n') takes 0.64s, and soft-broken lines with nothing linkifiable take 42ms. So it needs many children AND many of them linkifying. For the second, replaying just theSCHEME_REcalls against the same growing prefixes with no markdown-it involved accounts for 11.7s of the 15s.Ordinary prose does it too.
'ping a@b.co ok\n'.repeat(20000)is 293KB and takes 31s.Caveat
linkifyis off by default, so this only reaches apps that turn it on.Impact
Availability only. A few hundred KB of fairly ordinary markdown pins one core for tens of seconds, and because it's quadratic it degrades quickly with size. Nothing is read, written or executed.
Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
markdown-it/markdown-it (markdown-it)
v15.0.1Compare Source
Changed
Fixed
Security
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.