fix(android): replace destructive Room migration with real migration scaffold + safety export - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppDatabase(v3) is built withfallbackToDestructiveMigration(). Anyfuture schema change — adding a column, renaming a field — silently deletes
every profile on the user's device. Each profile carries the
tunnel_key(AES-256-GCM),
script_keys,socks_pass, andremoteUrl. Losing themrequires re-import, and losing the
tunnel_keysource locks the user outof their VPN permanently.
What changed
exportSchema = true, replacefallbackToDestructiveMigration()withaddMigrations(*ProfileMigrations.ALL).Missing migration now crashes instead of silently wiping data.
SafetyExportMigrationscaffold: readsall profile rows and writes a JSON snapshot to
cacheDirbefore anyschema change. If the export fails, Room throws
IllegalStateExceptioninstead of proceeding with data loss.
ALL = arrayOf()is empty untilthe first real v3→v4 migration is authored.
getAllOnce()for non-flowing snapshot access.ksp { arg("room.schemaLocation", ...) }forschema export,
androidTestImplementationdeps for future migrationtests.
getAllOnce()inNoopProfileDaotest fake (required after interface expansion).Verification
:app:assembleDebug— CI green on push ✓:app:testDebugUnitTest— CI green on push ✓fallbackToDestructiveMigrationgrep onsrc/main/→ 0 matches ✓deferred until emulator-backed CI is set up.