fix(android): register v2→v3 and v3→v4 Room migrations, bump DB to v4 - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers real Room migrations for the two schema gaps that crash existing
users upgrading to this build, and bumps the DB version to 4 so Room has a
version delta to act on.
Why:
fallbackToDestructiveMigration (removed in plan 003). Any user still on a
v2 DB now hits "A migration from 2 to 3 was required but not found".
(coalesceStepMs, idleSlotsPerBucket, remoteUrl added without a version
bump), so old v3 DBs crash on "no such column" for every SELECT *.
Changes:
existingColumns() guard so one Migration(3,4) handles both live v3 shapes
(13- and 15-column) and stays idempotent.
column adds).
wiring, v2→v4 data preservation, both v3 variants, idempotency).
Tests: ./gradlew :app:testDebugUnitTest → BUILD SUCCESSFUL, 5/5 pass.