Conversation
|
Sent this in Slack yesterday, but maybe should send here too. The ExtensionIO classes are not defined on this branch. My guess is that you just forgot to track them. To track them, run |
SCool62
left a comment
SCool62
left a comment
There was a problem hiding this comment.
Looks like your ExtensionIO classes aren't tracked, so this review isn't complete. My comments have also made assumptions about the ExtensionIO which might be wrong.
|
|
||
|
|
||
|
|
||
| private ExtensionIO io; |
There was a problem hiding this comment.
The lintake also has rollers, so add a roller io as well
|
|
||
| public void periodic() { | ||
| io.updateInputs(inputs); | ||
| Logger.processInputs("Extension", inputs); |
There was a problem hiding this comment.
Maybe log these to Intake/Extension
|
|
||
| // TODO get actual values | ||
| public Command extend() { | ||
| return this.run(() -> io.setExtensionVoltage(5)); |
There was a problem hiding this comment.
These should probably be on position control?
| private ExtensionIO io; | ||
| private ExtensionIOInputsAutoLogged inputs = new RollerIOInputsAutoLogged(); | ||
|
|
||
| private SysIdRoutine intakeRollerSysid = |
There was a problem hiding this comment.
Rename this because it's sysid for the extension not the rollers.
| return this.run(() -> io.setExtensionVoltage(0)); | ||
| } | ||
|
|
||
| public Command runRollerSysid() { |
There was a problem hiding this comment.
This file probably shouldn't be in this branch. To remove it, use git rm --cached vendordeps/playingwithfusion2026.json and commit (this will stop tracking the file without deleting it), or just move the file to trash and commit.
2 participants
No description provided.