Open
Conversation
spellingcat
requested changes
Feb 2, 2026
Member
spellingcat
left a comment
spellingcat
left a comment
There was a problem hiding this comment.
looks great overall. lmk when you're available to come to the field and you can test it pretty soon
Comment on lines
+623
to
+625
| ((Math.abs(getPose().getX() - 4.62) < 2) || (Math.abs(getPose().getX() - 11.91) < 2)) | ||
| && | ||
| ((getPose().getY() > 5.04 && getPose().getY() < 6.07) || (getPose().getY() > 2 && getPose().getY() < 3.01))) |
Member
There was a problem hiding this comment.
i'd recommend throwing these numbers for the coordinates (4.62, 11.91 etc) into FieldUtils.java as constants (so similar to the BLUE_HUB_POS that's already there) and then referencing them by name here to minimize the amount of "magic numbers" floating around in our code
| modifyJoystick(driver.getLeftX()) | ||
| * SwerveSubsystem.SWERVE_CONSTANTS.getMaxLinearSpeed())); | ||
|
|
||
| while(swerve.isCloseToBump()){ |
Member
There was a problem hiding this comment.
this is the right logic, although the while loop doesn't explicitly create a trigger object around this boolean value
Suggested change
| while(swerve.isCloseToBump()){ | |
| new Trigger(swerve::isCloseToBump).whileTrue(swerve.bumpAlign etc...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.