Add POM cleanup step to SCR→DS migration skill - #11
Open
bharat941 wants to merge 31 commits into
Open
Conversation
Remove asset-manager and event-migration reference files that are no longer needed: - asset-manager.md, asset-manager-create.md, asset-manager-delete.md - event-migration-path-a.md, event-migration-path-b.md Keeping core migration patterns: scheduler, replication, resource-change-listener, event-migration
Expand AEM Cloud Service migration skill with additional patterns: - Asset Manager: create/upload (Direct Binary Access) + delete (HTTP Assets API) - Event Migration: JCR EventListener → EventHandler + JobConsumer (Path A & B) New reference files: - asset-manager.md, asset-manager-create.md, asset-manager-delete.md - event-migration-path-a.md, event-migration-path-b.md Made-with: Cursor
feat(aem): add asset-manager and event-migration patterns
…sistencies - Rewrite BPA section to use agent-native instructions instead of JavaScript helper scripts - Remove references to ./scripts/bpa-findings-helper.js and ./unified-collections/ - Fix Step 4 path references to use relative paths (references/ instead of .cursor/skills/...) - Update Available Patterns table to use correct references/ directory name - Remove CLI Testing section that referenced nonexistent scripts - Simplify Quick Reference to match new BPA flow without collection caching
Add list-projects API contract and enforce always presenting project list to the user for confirmation before calling fetch-cam-bpa-findings, even when only one project exists. Includes updated example agent flow.
Add detailed transformation references for scheduler, event-migration, replication, resource-change-listener, and asset-manager patterns including path classification, step-by-step instructions, and validation.
When fetch-cam-bpa-findings returns success: false, the skill now stops immediately and reports the error to the user. It no longer falls back to Manual Flow or CSV. Made-with: Cursor
Keep STOP ON MCP ERROR rule: when fetch-cam-bpa-findings returns success: false, stop immediately. Integrate with beta's source priority and list-projects flow. Made-with: Cursor
fix: stop on MCP error instead of falling back to Manual Flow
Replace code-migration with aem-cloud-service-best-practices (pattern refs, scr-to-osgi-ds, resource-resolver-logging) and migration/ (orchestration + scripts). Update marketplace and README.
Migration: cam-mcp reference, path alias, quick start, dual-plugin install notes, description tweaks. Best-practices: JCR observation vs OSGi EventHandler wording, prerequisites phrasing. Remove sibling terminology; plugin.json copy; safe CAM example id.
Add capability for local bpa csv file
Keep removal of code-migration/aem-migration; migration is under migration/aem-cloud-service-migration.
Relocate the Cloud Service pattern package to skills/aem/cloud-service/skills/best-practices/ with SKILL.md and references/ at the plugin root (plugin id aem-best-practices). Move migration content out of the nested aem-cloud-service-migration folder into migration/ (plugin id aem-migration). Register aem-best-practices, aem-migration, aem-cloud-service-dispatcher, and aem-6-5-lts-dispatcher in .claude-plugin/marketplace.json. Update the repository README with install commands and the revised directory layout. Migration and CAM docs require explicit CAM project confirmation, verbatim MCP errors with no automatic fallback, and IDE workspace-scoped file discovery. Docs use aem-prefixed plugin names without extra marketplace commentary.
…nsolidation Aem cloud best practices skill consolidation
…nsolidation docs(migration): document CAM MCP enablement restriction verbatim errors
- Root npm test: skills-ref validate, migration unit tests, marketplace JSON parse - CI validate workflow runs npm test - SKILL frontmatter name must match folder (best-practices, migration) per skills-ref - Fixture CSV + node:test coverage for getBpaFindings and checkAvailableSources
…t-practices scope
…ranch Remove references/osgi-cfg-json-cloud-manager.md and all SKILL.md wiring (quick start, delegation, when-to-use). Keeps CAM/MCP tightening, workspace scope, and MCP error handling from refactoring.
Tighter fallback rules and error handling
When migrating Felix SCR to OSGi DS, the agent now also removes deprecated dependencies and plugins from pom.xml in the same change set. Adds Step 0 to scr-to-osgi-ds.md with concrete instructions to remove maven-scr-plugin, Felix SCR deps, legacy bndlib, and monolithic OSGi compendium JARs. Propagates POM checklist items to all pattern module validation checklists (scheduler, event-migration, replication, resource-change-listener). Adds CLEAN THE POM critical rule to SKILL.md. Made-with: Cursor
Remove instructions to delete org.osgi.core/compendium and to add new DS annotation dependencies. The skill should only remove POM deps for the exact APIs it migrated away from — nothing more, nothing less. Made-with: Cursor
Require rg search confirming zero remaining imports before any Felix SCR / bndlib POM dependency or plugin is removed. Made-with: Cursor
bharat941
pushed a commit
that referenced
this pull request
Apr 7, 2026
chore(deps): update actions/setup-node action to v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scr-to-osgi-ds.md) that removes themaven-scr-pluginand deprecated Felix SCR dependencies frompom.xmlalongside Java source migrations.felix.scr.annotations,bndlib). Does not remove unrelated deps likeorg.osgi.core/org.osgi.compendiumand does not add new dependencies proactively.Test plan
aem-guides-wknd-legacy— verify only SCR-related deps are removed from POMsmvn clean compilepasses after migrationorg.osgi.core/org.osgi.compendiumare left untouched if not directly migrated