[pull] 0.x from laravel:0.x#65
Merged
Merged
Conversation
Provider options set for Ollama via HasProviderOptions are all merged into the request body "options" object — Ollama's model-parameters bag (temperature, top_p, num_ctx, seed, …). But several Ollama request fields are top-level rather than model parameters, notably "format" (Ollama's JSON-mode switch) and "keep_alive". Ollama ignores them under "options", so there was no way to set "format" through provider options without dropping into the full schema path. buildChatRequestBody() now hoists the keys Ollama documents at the top level of POST /api/chat (format, keep_alive, think, logprobs, top_logprobs) to the body root and keeps everything else under "options". Genuine model parameters are untouched, and a schema-driven format still wins over a provider-options format. Tests added. Co-authored-by: cjmcintyre <cjmcintyre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )