Skip to content

fix: the logic issues on the messaging system #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jimuelle07 merged 1 commit into from
Jun 12, 2026
Merged

fix: the logic issues on the messaging system #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backend/src/config/socket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,18 @@ export const initializeSocket = (httpServer) => {

// ── send_message ───────────────────────────────────────────────────────────
socket.on('send_message', async ({ conversationId, itemId, content }) => {
console.log('[send_message] received', { conversationId, itemId, userId: socket.data.userId, contentLen: content?.length });

if (!conversationId || !itemId || !content?.trim()) {
console.warn('[send_message] REJECTED — missing field', { conversationId: !!conversationId, itemId: !!itemId, hasContent: !!content?.trim() });
socket.emit('error', { message: 'conversationId, itemId, and content are required' });
return;
}

try {
const conversation = await Conversation.findById(conversationId);
if (!conversation) {
console.warn('[send_message] REJECTED — conversation not found:', conversationId);
socket.emit('error', { message: 'Conversation not found' });
return;
}
Expand All @@ -91,7 +95,10 @@ export const initializeSocket = (httpServer) => {
const isReporterSender = conversation.reporter.toString() === userId;
const isFinderSender = conversation.finder.toString() === userId;

console.log('[send_message] auth check', { reporter: conversation.reporter.toString(), finder: conversation.finder.toString(), userId, isReporterSender, isFinderSender });

if (!isReporterSender && !isFinderSender) {
console.warn('[send_message] REJECTED — not a participant');
socket.emit('error', { message: 'Not authorized to send messages in this conversation' });
return;
}
Expand Down Expand Up @@ -126,13 +133,15 @@ export const initializeSocket = (httpServer) => {
}
}

console.log('[send_message] creating message', { conversationId, itemId, sender: userId, receiver: receiverId });
const newMessage = await Message.create({
conversation: conversationId,
item: itemId,
sender: userId,
receiver: receiverId,
content: content.trim(),
});
console.log('[send_message] message saved to DB:', newMessage._id.toString());

// Update conversation timestamp manually
conversation.updatedAt = new Date();
Expand All @@ -159,7 +168,7 @@ export const initializeSocket = (httpServer) => {
isMuted: conversation.mutedBy && conversation.mutedBy.some(id => id.toString() === receiverId)
});
} catch (err) {
console.error(`send_message error (room: ${conversationId}):`, err.message);
console.error(`[send_message] CAUGHT ERROR (room: ${conversationId}):`, err);
socket.emit('error', { message: 'Failed to send message. Please try again.' });
}
});
Expand Down
1 change: 1 addition & 0 deletions frontend/src/ItemDetailPage/ChatPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export default function ChatPanel({ itemId, conversationId: initialConvId, curre
socket.emit('stop_typing', { conversationId: activeConvId })
}

console.log('[ChatPanel] emitting send_message', { conversationId: activeConvId, itemId, socketConnected: socket?.connected })
socket.emit('send_message', {
conversationId: activeConvId,
itemId,
Expand Down
Loading