Repository navigation
fix(mentions): drop npub matching, match on name, suppress premature 'no match' - #163
Merged
ButtercupRobrts merged 2 commits intoNov 10, 2026
Merged
Conversation
… flash - npub removed from the substring match — random bech32 hits polluted the dropdown before relay-scored results arrived - match() now checks the kind-0 'name' field so externals whose displayName differs still surface - 'No matching users' now waits for the search to actually settle: debounce gap + in-flight fetch + async whitelist load + a 400ms stability grace; 'Searching relays…' shows throughout
Architecture Data flow Review 1 finding · reviewed
|
Dropping npub from the substring filter also hid users resolved from a pasted npub1.../nprofile1... query when they carry no name metadata. Decode-and-compare keeps exact identity matches working while partial strings still can't match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dropdown noise and a premature verdict in mention search:
npubremoved from the substring match — random bech32 substring hits filled the dropdown with non-matching users before relay-scored results arrivedmatch()now checks the kind-0namefield — external users whosedisplayNamediffers from theirnamewere being filtered outTest plan
tsc --noEmitclean@nameshows "Searching relays…" continuously until results land; no npub noise; no premature verdict@+ prefix in a composer — confirm matching-only rows and searching indicatorGenerated with Devin