Repository navigation
fix(zaplytics): don't credit LNURL servers as zappers for requestless receipts - #165
Merged
ButtercupRobrts merged 2 commits intoNov 10, 2026
Conversation
… receipts Receipts without an embedded zap request (anonymous or relay-stripped) attributed zapEvent.pubkey — the LNURL server's key — ranking lightning infrastructure as 'top zappers' and fabricating a shared multi-member supporter in the network graph. Zaps are flagged anonymous and grouped under a single 'Anonymous' bucket carrying only aggregate counts: no profile metadata propagates, loyalty and unique-zapper metrics treat the bucket consistently, and buildGraph excludes it from cross-member joins.
Architecture Data flow Review 1 finding · reviewed
|
…splace real supporters
- anonymous: !zapRequest?.pubkey — a {} or pubkey-less request fell back
to crediting the LNURL server anyway
- member.topZappers filters anonymous before the top-5 slice: it feeds
only the network graph, so an aggregate bucket can't displace an
identified supporter (community aggregate keeps the bucket)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zap receipts without an embedded zap request attributed the LNURL server's key as the sender, ranking lightning infrastructure as top zappers and fabricating a shared multi-member supporter in the contributor graph.
Flag requestless zaps anonymous and group them under a single 'Anonymous' bucket carrying only aggregate counts: no nip05/picture propagates, loyalty skips unknown senders, unique-zapper counts are consistent, and buildGraph excludes the bucket from cross-member joins.
Test: tsc clean; anonymous zaps render as one 'Anonymous' entry.