Skip to content

fix(zaplytics): remove hardcoded 100% success badge from hashtag cards - #166

Merged
ButtercupRobrts merged 1 commit into
HiveTalk:mainfrom
ButtercupRobrts:fix/remove-fake-success-rate
Nov 10, 2026
Merged

ButtercupRobrts merged 1 commit into
HiveTalk:mainfrom
ButtercupRobrts:fix/remove-fake-success-rate

Conversation

@ButtercupRobrts

Copy link
Copy Markdown
Collaborator

successRate is a hardcoded 100 (only zapped posts are ever tracked, so it's always 100%). Displaying it ships a knowingly fake metric — display removed until real all-posts data exists. Field kept in the type; dropped the now-unused TrendingUp import.

successRate is a hardcoded 100 — displaying it ships a knowingly fake
metric. Display removed until real all-posts tracking exists.
@coldtea-pr-lens

coldtea-pr-lens Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Architecture

Architecture diagram for HiveTalk/nostr-cms at c2754eb

Open the canvas


Data flow

No data-flow sequence changed in this PR.


Review

✨ Nothing flagged · reviewed c2754eb


Tip

Open a diagram on the canvas, then press W or click play to walk through the change one step at a time

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
  • Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

@ButtercupRobrts
ButtercupRobrts merged commit 5721b04 into HiveTalk:main Nov 10, 2026
7 checks passed
@ButtercupRobrts
ButtercupRobrts deleted the fix/remove-fake-success-rate branch November 10, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant