Skip to content

fix(app-server): require auth for non-loopback binds#3332

Draft
cyq1017 wants to merge 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-3258-app-server-auth
Draft

fix(app-server): require auth for non-loopback binds#3332
cyq1017 wants to merge 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-3258-app-server-auth

Conversation

@cyq1017

@cyq1017 cyq1017 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #3258

Summary

  • reject non-loopback app-server binds when no explicit auth token is supplied
  • keep loopback one-time token generation and explicit-token non-loopback binds unchanged
  • add regression coverage for the default non-loopback/no-token path

Verification

  • cargo fmt --check --all
  • cargo test -p codewhale-app-server non_loopback -- --nocapture
  • cargo test -p codewhale-app-server --lib --locked -- --nocapture
  • cargo test --workspace --all-features --locked non_loopback -- --nocapture
  • cargo clippy --workspace --all-features --locked -- -D warnings -A clippy::uninlined_format_args -A clippy::too_many_arguments -A clippy::unnecessary_map_or -A clippy::assertions_on_constants

Signed-off-by: cyq <15000851237@163.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a security check in resolve_auth_token that prevents the application server from binding to a non-loopback address unless an explicit authentication token is configured. It also adds a corresponding unit test to verify that attempting to bind to a non-loopback address without an explicit token fails as expected. There are no review comments, so no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app-server: fail fast for non-loopback legacy bind without explicit auth

1 participant