Skip to content

style(clippy): fix clippy warnings#3346

Open
hongqitai wants to merge 3 commits into
Hmbown:mainfrom
hongqitai:style/fix-clippy
Open

style(clippy): fix clippy warnings#3346
hongqitai wants to merge 3 commits into
Hmbown:mainfrom
hongqitai:style/fix-clippy

Conversation

@hongqitai

@hongqitai hongqitai commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • run cargo clippy --fix fix clippys
  • some test failed, but it wasn't due to the changes made this time.

Testing

  • [ x ] cargo fmt --all -- --check
  • [ x ] cargo clippy --workspace --all-targets --all-features
  • [ x ] cargo test --workspace --all-features

Checklist

  • [ x ] Updated docs or comments as needed
  • [ x ] Added or updated tests where relevant
  • [ x ] Verified TUI behavior manually if UI changes
  • [ x ] Harvested/co-authored credit uses a GitHub numeric noreply address

@hongqitai hongqitai requested a review from Hmbown as a code owner June 20, 2026 03:57

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors string formatting across the codebase to use Rust's inline format arguments, simplifies option mapping in retry_status.rs using is_none_or, and replaces a runtime assertion in ui/tests.rs with a comment in ui.rs. The reviewer suggests enforcing the MAX_ENGINE_EVENTS_PER_DRAIN limit using a compile-time assertion rather than just a comment.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/tui/src/tui/ui.rs Outdated

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@Hmbown

Hmbown commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Thanks @hongqitai — this was a useful cleanup for the v0.8.64 branch. I carried the non-benchmark slice locally as b292cd13b, preserving your authorship from the PR.

I intentionally kept the benchmark-harness changes out of the public CodeWhale release repo and handled that material separately, so this branch gets the Clippy cleanup without growing benchmark surface here.

Local verification:

  • cargo fmt --all -- --check
  • cargo test -p codewhale-tui --bin codewhale-tui --locked six_worker_progress_storm_keeps_input_render_and_cancel_live
  • cargo test -p codewhale-tui --bin codewhale-tui --locked tui::tab
  • cargo test -p codewhale-tui --bin codewhale-tui --locked ghost_text_renders_when_suggestion_set_and_input_empty
  • ./scripts/release/check-versions.sh
  • python3 scripts/check-coauthor-trailers.py --author-map .github/AUTHOR_MAP --range origin/main..HEAD --check-authors

I am leaving this PR open until the integration branch is pushed/landed so the visible GitHub state stays honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants