style(clippy): fix clippy warnings#3346
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Code Review
This pull request refactors string formatting across the codebase to use Rust's inline format arguments, simplifies option mapping in retry_status.rs using is_none_or, and replaces a runtime assertion in ui/tests.rs with a comment in ui.rs. The reviewer suggests enforcing the MAX_ENGINE_EVENTS_PER_DRAIN limit using a compile-time assertion rather than just a comment.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Thanks @hongqitai — this was a useful cleanup for the v0.8.64 branch. I carried the non-benchmark slice locally as I intentionally kept the benchmark-harness changes out of the public CodeWhale release repo and handled that material separately, so this branch gets the Clippy cleanup without growing benchmark surface here. Local verification:
I am leaving this PR open until the integration branch is pushed/landed so the visible GitHub state stays honest. |
Summary
cargo clippy --fixfix clippysTesting
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist