Skip to content

perf(tui): lower the settings filter once per pass, not once per row (#6213 T6) #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hmbown merged 1 commit into from
Sep 16, 2026
+18 −6
Merged

perf(tui): lower the settings filter once per pass, not once per row (#6213 T6) #6267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions crates/tui/src/tui/views/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2713,9 +2713,19 @@ impl ConfigView {
if cached == 0 { 8 } else { cached }
}

fn row_matches_filter(&self, row: &ConfigRow) -> bool {
let filter = self.filter.trim().to_lowercase();
if filter.is_empty() {
/// The lowercased search terms for the current filter, computed once per
/// interaction instead of once per row per pass (#6213 T6).
fn filter_terms(&self) -> Vec<String> {
self.filter
.trim()
.to_lowercase()
.split_whitespace()
.map(str::to_string)
.collect()
}

fn row_matches_filter(&self, row: &ConfigRow, terms: &[String]) -> bool {
if terms.is_empty() {
return true;
}

Expand All @@ -2733,7 +2743,7 @@ impl ConfigView {
let scope_en = row.scope.label(Locale::En).to_lowercase();
let hint = config_hint_for_key(self.locale, &row.key).to_lowercase();

filter.split_whitespace().all(|term| {
terms.iter().all(|term| {
section.contains(term)
|| section_en.contains(term)
|| category_label.contains(term)
Expand All @@ -2750,11 +2760,12 @@ impl ConfigView {

fn matching_row_indices(&self) -> Vec<usize> {
let filtering = !self.filter.is_empty();
let terms = self.filter_terms();
self.rows
.iter()
.enumerate()
.filter_map(|(idx, row)| {
(self.row_matches_filter(row) && (filtering || self.category.contains(row)))
(self.row_matches_filter(row, &terms) && (filtering || self.category.contains(row)))
.then_some(idx)
})
.collect()
Expand All @@ -2765,8 +2776,9 @@ impl ConfigView {
let mut current_section = None;
let filtering = !self.filter.is_empty();

let terms = self.filter_terms();
for (idx, row) in self.rows.iter().enumerate() {
if !self.row_matches_filter(row) {
if !self.row_matches_filter(row, &terms) {
continue;
}
// The rail category filters rows unless the user is searching.
Expand Down
Loading