Modalities: generalize OO_conn_map_isconnected and other results#2371
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generalizes OO_conn_map_isconnected (and related results) in Modalities.Descent to allow maps from an O-connected type to an O'-connected type, and then specializes the result to truncation modalities.
Changes:
- Export
O_lex_leq_TrsoTr n <<< Tr n.+1is available globally to typeclass search. - Strengthen
OO_conn_map_isconnected,OO_isconnected_hfiber,OO_isequiv_mapino_isconnected, andOO_conn_map_functor_hfiberto require onlyIsConnected Oon the domain side where applicable. - Add the truncation-specialized lemma
isconnmap_isconnectedand simplifyconn_point_inclusing the generalized descent lemma.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| theories/Truncations/SeparatedTrunc.v | Exports O_lex_leq_Tr : Tr n <<< Tr n.+1 for reuse via typeclass search. |
| theories/Truncations/Connectedness.v | Adds isconnmap_isconnected (truncation specialization) and simplifies conn_point_incl. |
| theories/Modalities/ReflectiveSubuniverse.v | Adds helper equivalence equiv_O_functor_to_O_O_leq. |
| theories/Modalities/Descent.v | Generalizes OO_conn_map_isconnected and downstream lemmas to weaker connectivity hypotheses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
The comments about generalizing RSS were wrong, since to get the results in RSS you already had to specialize to O = O'. Once this is ready to merge, I'll squash commits 2, 3 and 4 together. |
Alizter
approved these changes
Jun 18, 2026
dc4a64f to
713809e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OO_conn_map_isconnectedis generalized to say that any map from an O-connected type to an O'-connected type is O-connected. It used to require that both types were O'-connected. The proof is just a few lines, and trivially allows us to generalize three other results. We also state the special case for n-truncations asisconnmap_isconnected, which will be useful for #2369.As a helper result, we add the one-liner
equiv_O_functor_to_O_O_leqto ReflectiveSubuniverse.v.That's all in the second commit. The first commit exports the previously local instance
O_lex_leq_Tr. I didn't notice any problems with it exported, and it comes up inisconnmap_isconnectedand will in general make it easier to apply results from Descent.v.