Skip to content

Comments

DEV-229 Infinite Scroll#40

Merged
jfmath04 merged 11 commits intopreviewfrom
infinite-scroll
Dec 2, 2025
Merged

DEV-229 Infinite Scroll#40
jfmath04 merged 11 commits intopreviewfrom
infinite-scroll

Conversation

@anna-1au
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Nov 13, 2025

DEV-229 Infinite Scroll

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
stuff Ready Ready Preview Comment Nov 25, 2025 9:21pm

Comment on lines 5 to 25
name: Run linters
runs-on: ubuntu-latest

steps:
- name: Check out Git repository
uses: actions/checkout@v5

- name: Set up Node.js
uses: actions/setup-node@v5
with:
node-version: 22

# ESLint and Prettier must be in `package.json`
- name: Install Node.js dependencies
run: yarn install --frozen-lockfile

- name: Run linters
uses: wearerequired/lint-action@v2.3.0
with:
eslint: true
prettier: true

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 3 months ago

To fix the problem, add a permissions block to restrict the GITHUB_TOKEN privileges for the job. For this workflow and job, setting permissions: contents: read at the job level is typically sufficient for linting tasks, which only need to read repository files and do not need to push, modify, or create artifacts/issues/pull-requests. To implement this, add the following block directly under the job definition line (run-linters:) and above runs-on: ubuntu-latest. No imports, definitions, or additional methods are needed. Adjust the indentation so that it matches the current job indentation.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -3,6 +3,8 @@
 jobs:
     run-linters:
         name: Run linters
+        permissions:
+            contents: read
         runs-on: ubuntu-latest
 
         steps:
EOF
@@ -3,6 +3,8 @@
jobs:
run-linters:
name: Run linters
permissions:
contents: read
runs-on: ubuntu-latest

steps:
Copilot is powered by AI and may make mistakes. Always verify output.
@anna-1au anna-1au requested a review from jfmath04 November 13, 2025 03:48
@jfmath04 jfmath04 changed the base branch from main to preview November 13, 2025 04:18
Copy link
Contributor

@jfmath04 jfmath04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks very good! Just run linting and prettier to fix those errors. Also, add the package.json and yarn.lock files since you added a new package.

Copy link
Contributor

@jfmath04 jfmath04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The infinite scroll looks good! Let's remove the package-lock.json file though. Also run yarn build and fix any errors you see from that.

Copy link
Contributor

@jfmath04 jfmath04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ZhaoSongZh7 ZhaoSongZh7 self-requested a review December 2, 2025 05:09
Copy link
Contributor

@ZhaoSongZh7 ZhaoSongZh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite scroll looks good on the website and code changes look good!

@jfmath04 jfmath04 merged commit e03ac9d into preview Dec 2, 2025
5 checks passed
@jfmath04 jfmath04 deleted the infinite-scroll branch December 2, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants