Update build.yml#174
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f4e9a3e2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| & msbuild $sln /t:Restore @args | ||
| if ($LASTEXITCODE -ne 0) { throw "MSBuild restore failed: $repoName ($cfg)" } |
There was a problem hiding this comment.
The Revit builds were moved into separate steps, but those steps invoke msbuild without re-setting ReferencePath. In GitHub Actions, environment variables assigned in one step (like $env:ReferencePath in the shared-deps step) do not persist to later steps unless exported via GITHUB_ENV, so Build + snapshot Revit 2025/2026 runs with the default reference search path. If SAM_Revit_UI or SAM_Revit resolve dependencies from SAM_Windows\build or SAM_UI\build, these steps will fail with unresolved references even though the shared dependency step succeeded.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
fix build
Validation
How to verify or test the change.