-
Notifications
You must be signed in to change notification settings - Fork 5
Q2 2026 — System.Text.Json migration + quarterly work #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaldengusiak
wants to merge
14
commits into
HoareLea:master
Choose a base branch
from
SAM-BIM:sow/2026-Q2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
48647ef
Migrate Revit JSON code to System.Text.Json
michaldengusiak f6a1792
CI: prefer sow/2026-Q2 for dep clones + trigger on it
michaldengusiak 1aa6e37
CI: cascade dep clones to PR head_ref -> sow/2026-Q2 -> default
michaldengusiak ef850e5
Add SPDX + copyright header to migration-touched files
michaldengusiak 0d75d84
CI: pass auth token through cascade ls-remote and clone
michaldengusiak 5610456
Remove defensive Newtonsoft.Json package references
michaldengusiak 1eba45e
Merge pull request #2 from SAM-BIM/feature/remove-newtonsoft
michaldengusiak bcd0c1f
Pin System.Text.Json to 8.0.5
michaldengusiak 85853de
Pin System.Text.Json to 8.0.5 and strip empty <NoWarn /> tags
michaldengusiak 3555b24
Merge pull request #3 from SAM-BIM/fix/system-text-json-pin-8.0.5
michaldengusiak b42ad0b
fix: pin AssemblyVersion/FileVersion to 1.0.0.0 (#4)
michaldengusiak 0e33592
build: Directory.Build.props for centralised SAMVersion stamping (#5)
michaldengusiak b617a0a
build: emit AssemblyInformationalVersion for non-SDK projects
michaldengusiak 0f928b3
build: emit AssemblyInformationalVersion for non-SDK projects
michaldengusiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| <Project> | ||
|
|
||
| <PropertyGroup> | ||
| <!-- Local dev builds default to 1.0.0.0. CI passes /p:SAMVersion=YYYY.Q.<run_number>.0. --> | ||
| <SAMVersion Condition="'$(SAMVersion)' == ''">1.0.0.0</SAMVersion> | ||
| <AssemblyVersion>$(SAMVersion)</AssemblyVersion> | ||
| <FileVersion>$(SAMVersion)</FileVersion> | ||
| <!-- | ||
| InformationalVersion: the content-identity stamp (SemVer +build metadata). | ||
| Composed from SAMVersion + SAMSourceRevision when CI sets the latter. If CI already | ||
| set InformationalVersion directly (e.g. SAM_Deploy installer.yml does this), respect | ||
| that and don't overwrite. Local dev builds leave both empty -> no SHA attribute emitted. | ||
| --> | ||
| <InformationalVersion Condition="'$(InformationalVersion)' == '' AND '$(SAMSourceRevision)' != ''">$(SAMVersion)+$(SAMSourceRevision)</InformationalVersion> | ||
| <!-- | ||
| Suppress the SDK's SourceLink auto-append behaviour. By default, when SourceLink is | ||
| configured on a project (via NuGet or repo settings), the SDK appends the project's | ||
| OWN commit SHA to InformationalVersion (e.g. '2026.2.164.0+998af06.dd02a4c2...'). | ||
| We set InformationalVersion explicitly to SAM_Deploy's SHA (which encodes all 22 | ||
| submodule pointers), so the SDK's extra append is noise. False = keep our value clean. | ||
| --> | ||
| <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion> | ||
| <Deterministic>true</Deterministic> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- | ||
| Projects where SDK assembly-attribute generation is disabled (legacy AssemblyInfo.cs | ||
| with GenerateAssemblyInfo=false) OR projects where the SDK doesn't auto-generate | ||
| attributes at all (classic-style csprojs that don't set the property — '' evaluates | ||
| as not 'true') ignore the AssemblyVersion/FileVersion MSBuild properties above. | ||
| Inject the attributes via a generated source file so those assemblies also get | ||
| stamped by CI. | ||
| --> | ||
| <Target Name="_GenerateSAMVersionFile" | ||
| BeforeTargets="CoreCompile" | ||
| Condition="'$(GenerateAssemblyInfo)' != 'true'"> | ||
| <ItemGroup> | ||
| <_SAMVersionLine Include="// <auto-generated />" /> | ||
| <_SAMVersionLine Include="[assembly: System.Reflection.AssemblyVersionAttribute("$(SAMVersion)")]" /> | ||
| <_SAMVersionLine Include="[assembly: System.Reflection.AssemblyFileVersionAttribute("$(SAMVersion)")]" /> | ||
| <!-- Only emit InformationalVersion attribute when CI provided a value (SDK projects | ||
| would otherwise get it via PropertyGroup -> SDK auto-gen). --> | ||
| <_SAMVersionLine Include="[assembly: System.Reflection.AssemblyInformationalVersionAttribute("$(InformationalVersion)")]" Condition="'$(InformationalVersion)' != ''" /> | ||
| </ItemGroup> | ||
| <MakeDir Directories="$(IntermediateOutputPath)" /> | ||
| <WriteLinesToFile | ||
| File="$(IntermediateOutputPath)SAMVersion.g.cs" | ||
| Lines="@(_SAMVersionLine)" | ||
| Overwrite="true" | ||
| WriteOnlyWhenDifferent="true" /> | ||
| <ItemGroup> | ||
| <Compile Include="$(IntermediateOutputPath)SAMVersion.g.cs" KeepDuplicates="false" /> | ||
| <FileWrites Include="$(IntermediateOutputPath)SAMVersion.g.cs" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| </Project> |
5 changes: 4 additions & 1 deletion
5
Grasshopper/SAM.Analytical.Grasshopper.Revit/Kernel/AssemblyInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this workflow runs on
pushorworkflow_dispatch,github.head_refis empty, so the candidate list becomes onlysow/2026-Q2(then default). Because line 93 unconditionally prioritizessow/2026-Q2, builds onmaster/mainwill clone and compile dependency repos from that quarter branch whenever it exists, instead of the branch being validated. This can mask real integration breakages (or create false failures) by testing SAM_Revit against mismatched dependency revisions.Useful? React with 👍 / 👎.