Allow choosing Celsius or Farenheit for temp#4
Open
akileos wants to merge 1 commit into
Open
Conversation
Owner
|
It's a good change, but it takes away the option to display both (which is how I prefer it, to become more familiar with both standards). Maybe add a third option - like "b" for "both", or "cf" for "celsius/fahrenheit" - which keeps things as they were before? "c" can stay the default though as that's what the vast majority of countries use. |
Contributor
Author
|
Will check when I can do that, no problem, just an elseif block :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.