Show dependency status for casks (✔/✘) #17982
Conversation
|
Please provide a better issue/pull request title and/or description! |
request-info
bot
added
the
needs response
HaraldNordgren
force-pushed
the
cask_deps
branch
13 times, most recently
from
1a92ff5 to
f6318c6
Compare
|
The issue that I run into so far is that when cask dependencies are just strings, so it fails when trying to check if they are satisfies in For the formula the dependencies a a fully-fledged type. |
|
@HaraldNordgren I'm game to help more if you want to keep this open? |
|
Thanks @MikeMcQuaid! After the vacation period, I am now back on my full-time job again. Combined with having kids, this doesn't leave a ton of time to work on open source, unfortunately. I will re-open this if I get some inspiration! 🤗 |
|
@HaraldNordgren Thanks for the heads up! |
HaraldNordgren
force-pushed
the
cask_deps
branch
from
f6318c6 to
84510d4
Compare
HaraldNordgren
changed the title
|
Hi @MikeMcQuaid! One year later and I'm on winter vacation so I have some time again 🎄 I think I got it to work now, do you want to take a look? 🤗 |
Library/Homebrew/utils/output.rb
Outdated
| def pretty_uninstalled(string) | ||
| if !$stdout.tty? | ||
| string | ||
| "#{string} ✘" |
There was a problem hiding this comment.
Without these changes, I couldn't find a way to assert my changes.
Unfortunately, this requires changes to a lot of other tests. Is there a better way?
There was a problem hiding this comment.
Ensure that stdout.tty is mocked to false. Cannot accept these changes as-is.
There was a problem hiding this comment.
@MikeMcQuaid Is there a canonical way to achieve that? I tried a few things before and couldn't get that to work.
There was a problem hiding this comment.
@MikeMcQuaid I found a way now, there will be a lot of control characters in the test output, is it worth it?
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Changes look good so far, bar comment.
Library/Homebrew/utils/output.rb
Outdated
| def pretty_uninstalled(string) | ||
| if !$stdout.tty? | ||
| string | ||
| "#{string} ✘" |
There was a problem hiding this comment.
Ensure that stdout.tty is mocked to false. Cannot accept these changes as-is.
2 participants
When showing cask dependency info, also show the installation status.
This mirrors how it already works for formulas.