Skip to content

wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld#195828

Merged
BrewTestBot merged 4 commits intomasterfrom
wasm-component-ld
Nov 1, 2024
Merged

wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld#195828
BrewTestBot merged 4 commits intomasterfrom
wasm-component-ld

Conversation

@carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is needed to enable the rust formula to target WASI, and will
enable us to remove existing uses of rustup at build-time.

brew audit --new fails because of the notability check, but I think we
can/should make an exception for this.

@carlocab carlocab added notability Project is not notable enough for inclusion CI-skip-new-formulae Pass --skip-new to brew test-bot. labels Oct 28, 2024
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 28, 2024
@carlocab carlocab added the maintainer feedback Additional maintainers' opinions may be needed label Oct 28, 2024
@cho-m
Copy link
Member

cho-m commented Oct 28, 2024

I think there is a vendored copy in Rust and a wrapper around it https://github.com/rust-lang/rust/tree/1.82.0/src/tools/wasm-component-ld. It is currently built, but haven't checked if this was intended, e.g.

fd wasm-component-ld /opt/homebrew/opt/rust/
/opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld/opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld --version
wasm-component-ld 0.5.7

@carlocab
Copy link
Member Author

carlocab commented Oct 28, 2024

Yep, I found that, but after testing it (for wasm-wasip2 target at #195823) didn't seem to work. Not sure if I was just using it wrong.

@cho-m
Copy link
Member

cho-m commented Oct 28, 2024

Having a separate formula is also fine.

I also wasn't sure if Rust was supposed to include the wasm-component-ld. I did see there was a PR to change build condition at rust-lang/rust#130034 (merged but planned for 1.83.0)

@carlocab carlocab force-pushed the wasm-component-ld branch 3 times, most recently from 394f31e to a0f2e89 Compare October 30, 2024 02:27
@carlocab carlocab mentioned this pull request Oct 30, 2024
6 tasks
@carlocab carlocab changed the title wasm-component-ld 0.5.10 (new formula) wasm-component-ld 0.5.10 (new formula), wasi-runtimes: various fixes Oct 30, 2024
@carlocab carlocab force-pushed the wasm-component-ld branch 2 times, most recently from c3f6e38 to 75b439d Compare October 30, 2024 06:17
This is needed to enable the `rust` formula to target WASI, and will
enable us to remove existing uses of `rustup` at build-time.
This doesn't detect the features of our toolchain correctly without it.
@carlocab carlocab changed the title wasm-component-ld 0.5.10 (new formula), wasi-runtimes: various fixes wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld Nov 1, 2024
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Nov 1, 2024
@carlocab carlocab added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 1, 2024
@BrewTestBot BrewTestBot enabled auto-merge November 1, 2024 10:03
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 5de971b Nov 1, 2024
@BrewTestBot BrewTestBot deleted the wasm-component-ld branch November 1, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants