wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld#195828
Merged
BrewTestBot merged 4 commits intomasterfrom Nov 1, 2024
Merged
wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld#195828BrewTestBot merged 4 commits intomasterfrom
wasm-component-ld#195828BrewTestBot merged 4 commits intomasterfrom
Conversation
Member
|
I think there is a vendored copy in Rust and a wrapper around it https://github.com/rust-lang/rust/tree/1.82.0/src/tools/wasm-component-ld. It is currently built, but haven't checked if this was intended, e.g. ❯ fd wasm-component-ld /opt/homebrew/opt/rust/
/opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld
❯ /opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld --version
wasm-component-ld 0.5.7 |
Member
Author
|
Yep, I found that, but after testing it (for |
Member
|
Having a separate formula is also fine. I also wasn't sure if Rust was supposed to include the |
394f31e to
a0f2e89
Compare
carlocab
commented
Oct 30, 2024
a0f2e89 to
3ac89c5
Compare
6 tasks
carlocab
commented
Oct 30, 2024
c3f6e38 to
75b439d
Compare
This is needed to enable the `rust` formula to target WASI, and will enable us to remove existing uses of `rustup` at build-time.
This doesn't detect the features of our toolchain correctly without it.
75b439d to
52fbd98
Compare
wasm-component-ld
SMillerDev
approved these changes
Nov 1, 2024
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This is needed to enable the
rustformula to target WASI, and willenable us to remove existing uses of
rustupat build-time.brew audit --newfails because of the notability check, but I think wecan/should make an exception for this.