Skip to content

refactor(chat): clarify the single action surface #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HomenShum merged 1 commit into from
Jul 17, 2026
Merged

refactor(chat): clarify the single action surface #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/ai-ui/PrimitiveMigration.guard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const migratedSurfaces = [
"src/features/redesign/components/CommandPalette.tsx",
"src/layouts/chrome/CommandPalette.tsx",
"src/features/redesign/components/MessageActions.tsx",
"src/features/redesign/components/RightInspector.tsx",
"src/shared/ui/SurfacePrimitives.tsx",
"src/features/redesign/surfaces/ReportsSurface.tsx",
"src/layouts/settings/SettingsModal.tsx",
Expand Down
10 changes: 5 additions & 5 deletions src/features/redesign/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ All redesign code is scoped to `[data-redesign]`. The active shell shares the li

## File map

The active runtime tree is `RedesignShell` → `TopNav` + `ChatSurface` + the conditional
`RightInspector`. The remaining historical surface modules are retained only as
The active runtime tree is `RedesignShell` → `TopNav` + `ChatSurface`. Runtime scope,
evidence, receipts, and source review live progressively inside the conversation instead
of a parallel inspector. The remaining historical surface modules are retained only as
unmounted migration references while their reusable runtime fragments are folded into
the conversation; adding them back to `RedesignShell` violates the one-surface guard.

Expand All @@ -39,7 +40,6 @@ src/features/redesign/
│ ├── UniversalComposer.tsx Claude/ChatGPT-style composer · tier dropdown · + menu · send circle
│ ├── Pill.tsx tone-mapped status pill (accent / green / blue / amber / red)
│ ├── CardStack.tsx 3-column max graph traversal · breadcrumb + Back · drill / promote
│ ├── RightInspector.tsx chat right rail · Report status · Active entity · Graph · Sources · Threads
│ └── MobileShell.tsx capture-first phone shell · bottom 5-tab nav · bottom sheets
│
└── surfaces/
Expand All @@ -57,7 +57,7 @@ src/features/redesign/

| Path | Renders |
|---|---|
| `/redesign/chat` | The canonical `ChatSurface`, with a contextual runtime inspector after a run starts |
| `/redesign/chat` | The canonical `ChatSurface`, with progressive runtime and evidence detail inside each run |
| `/redesign/chat/r/:hash` | The same conversation with an immutable receipt loaded as context and the composer still available |
| `/redesign`, `/redesign/reports/*`, `/redesign/inbox`, `/redesign/me`, `/redesign/workspace` | Context-preserving replace into `/redesign/chat` |
| Main-site `/reports/:id` and its brief/cards/notebook/sources/graph/map tabs | Report and artifact context in `/redesign/chat`; recursive editing stays on the Workspace hostname |
Expand Down Expand Up @@ -165,7 +165,7 @@ import {
} from "@/features/redesign/components/UniversalComposer";

<UniversalComposer
contextLabel="Asking about: Orbital Labs" // top-left chip
contextLabel="Orbital Labs" // top-left context chip
onContextChange={() => {/* open picker */}} // chip click
onSubmit={(text, tier) => {/* dispatch */}} // Enter or send-button click
tier="auto" // controlled tier (omit for uncontrolled)
Expand Down
19 changes: 5 additions & 14 deletions src/features/redesign/RedesignShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ import "./tokens.css";
import "./primitives.css";
import "./agent-workspace.css";

import { RightInspector, type AgentRailSnapshot } from "./components/RightInspector";
import { TopNav } from "./components/TopNav";
import { ChatSurface } from "./surfaces/ChatSurface";
import type { LiveArtifactDetail } from "./hooks/useLiveArtifacts";
import { parseChatLaunchParams } from "./lib/chatContinuation";
import { canonicalRedesignChatTarget, pathToChatHash } from "./lib/oneSurfaceRouting";

Expand All @@ -29,8 +27,6 @@ export default function RedesignShell() {
const location = useLocation();
const navigate = useNavigate();
const [theme, setTheme] = useState<"light" | "dark">(readInitialTheme);
const [activeChatDetail, setActiveChatDetail] = useState<LiveArtifactDetail | null>(null);
const [activeChatAgentRail, setActiveChatAgentRail] = useState<AgentRailSnapshot | null>(null);

const canonicalTarget = useMemo(
() => canonicalRedesignChatTarget(location.pathname, location.search),
Expand All @@ -39,7 +35,6 @@ export default function RedesignShell() {
const chatLaunch = useMemo(() => parseChatLaunchParams(location.search), [location.search]);
const routeChatHash = useMemo(() => pathToChatHash(location.pathname), [location.pathname]);
const continuationHash = chatLaunch.continuationHash ?? routeChatHash ?? undefined;
const showChatInspector = Boolean(activeChatAgentRail?.hasIntent);

useEffect(() => {
if (canonicalTarget) navigate(canonicalTarget, { replace: true });
Expand All @@ -62,6 +57,10 @@ export default function RedesignShell() {
data-redesign
data-redesign-theme={theme}
data-product-surface="decision-workspace"
data-screen-id="decision-workspace"
data-screen-title="NodeBench"
data-screen-path="/redesign/chat"
data-screen-state="ready"
style={{
height: "100dvh",
overflow: "hidden",
Expand All @@ -75,7 +74,7 @@ export default function RedesignShell() {
/>

<div
className={`rd-shell rd-shell--home-v2 rd-shell--chat-v3 rd-shell--chat-focus ${showChatInspector ? "" : "rd-shell--chat-no-inspector"}`}
className="rd-shell rd-shell--home-v2 rd-shell--chat-v3 rd-shell--chat-focus rd-shell--chat-no-inspector"
style={{ flex: 1, minHeight: 0 }}
>
<div className="rd-shell__main">
Expand All @@ -84,18 +83,10 @@ export default function RedesignShell() {
<ChatSurface
initialPrompt={chatLaunch.prompt}
continuationHash={continuationHash}
onActiveContextChange={setActiveChatDetail}
onAgentRailChange={setActiveChatAgentRail}
/>
</div>
</main>

{showChatInspector && (
<RightInspector
activeLiveArtifactDetail={activeChatDetail ?? undefined}
agentSnapshot={activeChatAgentRail}
/>
)}
</div>
</div>

Expand Down
56 changes: 34 additions & 22 deletions src/features/redesign/agent-workspace.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,9 @@
}

[data-redesign] .rd-shell--chat-v3 .rd-shell__main {
grid-template-columns: minmax(0, 1fr) 320px;
}

[data-redesign] .rd-shell--chat-v3.rd-shell--chat-no-inspector .rd-shell__main {
grid-template-columns: minmax(0, 1fr);
}

[data-redesign] .rd-shell--chat-v3 .rd-pane--right.chat-context {
width: 320px;
}

[data-redesign] .rd-shell--chat-v3 .rd-shell__main > .rd-pane:first-child {
align-items: stretch;
padding: 0;
Expand Down Expand Up @@ -157,13 +149,30 @@
}

.rd-account-menu {
min-width: 170px;
width: min(340px, calc(100vw - 24px));
border-color: var(--rd-line);
background: var(--rd-panel);
color: var(--rd-ink);
font-family: var(--rd-font-sans);
}

.rd-account-menu .rd-account-voice {
margin: 4px;
border-radius: 12px;
padding: 12px;
box-shadow: none;
}

[data-redesign] .rd-composer-submit {
width: 36px;
height: 36px;
min-height: 36px;
padding: 0;
border-radius: 50%;
display: inline-grid;
place-items: center;
}

[data-redesign] .rd-launch-context {
display: grid;
gap: 4px;
Expand Down Expand Up @@ -204,13 +213,26 @@
list-style-position: inside;
}

[data-redesign] .rd-run-scope > summary span:nth-of-type(2) {
[data-redesign] .rd-run-scope__icon {
flex: 0 0 auto;
color: var(--rd-green);
}

[data-redesign] .rd-run-scope > summary span:first-of-type {
min-width: 0;
flex: 1;
max-width: 36ch;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

[data-redesign] .rd-run-scope > summary span:last-of-type {
flex: 0 0 auto;
color: var(--rd-ink-soft);
white-space: nowrap;
}

[data-redesign] .rd-run-scope dl {
display: grid;
gap: 6px;
Expand Down Expand Up @@ -259,12 +281,6 @@
line-height: 1.2;
}

[data-redesign] .rd-chat-empty__sub {
max-width: 58ch;
font-size: 14px;
line-height: 1.5;
}

[data-redesign] .rd-chat-empty__chips {
grid-template-columns: repeat(3, minmax(0, 1fr));
gap: 8px;
Expand Down Expand Up @@ -296,18 +312,14 @@
gap: 8px;
}

[data-redesign] .rd-run-scope > summary span:nth-of-type(2) {
[data-redesign] .rd-run-scope > summary span:first-of-type {
display: block;
min-width: 0;
flex: 1;
max-width: none;
}

[data-redesign] .rd-run-scope > summary span:nth-of-type(3) {
display: none;
}

[data-redesign] .rd-run-scope > summary span:nth-of-type(4) {
[data-redesign] .rd-run-scope > summary span:last-of-type {
flex: 0 0 auto;
}

Expand Down
2 changes: 0 additions & 2 deletions src/features/redesign/components/ChatEmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ export function ChatEmptyState({ onPick, starters = STARTERS }: ChatEmptyStatePr
return (
<div className="rd-chat-empty">
<div className="rd-chat-empty__hero">
<div className="rd-chat-empty__avatar" aria-hidden="true">✦</div>
<h2 className="rd-chat-empty__h">What do you need to know?</h2>
<p className="rd-chat-empty__sub">Ask from saved memory or start a sourced research run.</p>
</div>

<div className="rd-chat-empty__chips">
Expand Down
Loading
Loading