fix(redesign): design nitpick pass — honest dark captures, state copy, icons, row layout#574
Merged
Conversation
…py, chip icons Four findings from the pixel review of the 4-variant dogfood captures: - The capture spec's setTheme wrote only the legacy cockpit keys; the redesign shell reads nodebench:redesign:theme, so every "dark" variant screenshot silently captured a light render — QA evidence claimed coverage it did not have. The spec now writes the shell's key. - The context-miss banner titled itself "Notebook context selected" while its body admitted the saved context was unavailable; the title now agrees with the state for the artifact and default branches. - The composer status row repeated the context title the chip below it already carries, which pushed the load-bearing "12 attached sources" count into ellipsis at 390px. The row now leads with the count. - Starter chips used platform emoji; they now use the inline stroke-SVG house style via a shared STARTER_ICONS set so the default and live chip sets cannot drift apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
flex: 1 + max-width: 36ch reserved a title-sized column in the composer status row; with the title moved to the context chip, the short source count left dead space and "Review · no shared writes" floated mid-row on desktop. Content-sized now, with shrink + ellipsis kept for pressure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
HomenShum
enabled auto-merge (squash)
July 17, 2026 20:30
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
HomenShum
added a commit
that referenced
this pull request
Jul 17, 2026
…t evidence folder (#576) * feat(qa): L3 answer-packet state schemas + one-page surface-contract spec The contract gains "verifiable meaning": an answerPacket section declares, per response shape x evidence support, which packet fields MUST appear, which must NEVER leak (compact rendering is driven by field emptiness, so a leak is a rendered regression), and which honesty markers are required (Source needed prefixes, limitation risk rows). A new executor drives every declaration through the REAL detectRequestedResponseShape + applyDeterministicResponsePolicy — 8 shapes x supported/unsupported plus detector agreement, 25 tests from one JSON file — and joins the runtime-smoke allowlist. SPEC.md distills the pattern to one portable page (three layers, schema, verifier contract incl. independent replay, fail-closed hash binding for served projections) so the second in-portfolio implementation can converge on one spec instead of two bespoke ones. Reversion-proved: flipping the bullets lineCount clause fails exactly the two bullets tests; restored, 25/25. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(ui-contract): first dated evidence folder — nitpick pass before/after Five before/after pairs (desktop+mobile x dark+light + the forced context-miss state) regenerated honestly: before = pre-#574 sources rebuilt and captured with the FIXED spec so both sides render true dark. Schema-valid manifest per the ui-contract folder convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: hshum <hshum@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pixel review of all 4-variant dogfood captures (desktop/mobile × dark/light + interaction states) after the recent workspace changes. Six findings; five fixed, one accepted-by-design. Loop ran three capture passes and converged at zero new findings.
setThemewrote only the legacy cockpit theme keys;RedesignShell(the only surface since feat: make chat the single NodeBench workspace #561) readsnodebench:redesign:theme. Every "dark" screenshot was a mislabeled light render. The spec now writes the shell's key; pass-2 captures are the first honest dark evidence this pipeline has produced.STARTER_ICONSstroke-SVG set so the default and live chip sets cannot drift.flex: 1+max-width: 36chreserved a title-sized column in the run-scope summary, leaving "Review · no shared writes" floating mid-row on desktop. Content-sized now, shrink + ellipsis kept.Verification
npx tsc --noEmit— 0 errors🤖 Generated with Claude Code