chore(platform): align NodeBench with NodeKit v1 contracts#592
Draft
HomenShum wants to merge 2 commits into
Draft
chore(platform): align NodeBench with NodeKit v1 contracts#592HomenShum wants to merge 2 commits into
HomenShum wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 10365 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Aligns NodeBenchAI's current post-Phase-2 tree with the frozen NodeKit v1 contracts without moving runtime code or changing production behavior. Supersedes #591 with a branch and title that satisfy this repository's required PR-style policy.
What changed
nodekit.repo/v1,nodeagent.application/v1, andnodeagent.pack/v1manifestsrepo-local-nodebenchauthoritative while recordingnodeagent-nativeas the migration targetnodeagent.policy-contextdependency for the existing DeepTrace domain specializationconvex.json.functions(backend/convex) instead of hardcoding the pre-migrationconvex/pathRoot cause
The standard-tree migration moved Convex functions to
backend/convex/and correctly updatedconvex.json, butscripts/preflight-deploy.mjsretained a hardcodednpx tsc -p convex. PR #591 also used acodex/head and non-Conventional title, while this repository requires<type>/<slug>branches and Conventional Commit PR titles.Validation
npx vitest run scripts/__tests__/releaseWorkflowContracts.test.ts --reporter=verbose: 11/11 passedbackend/convexnpx tsc --noEmit --pretty false: passedce762d645646cb409ea3e20e58517608ce921dc9262eae8aa3377847bfc4594fgit diff --check: passedHonest boundary
This remains brownfield contract alignment. It does not edit the live Convex/agent loop, deploy anything, add Pi AI to production, claim a no-key application demo, or promote NodeBenchAI from
commandProfile: untracked. That command profile should remain untracked until NodeBench has an honest finite no-key lifecycle rather than production credentials and a service command.