Skip to content

Reconcile NodeRoom's Pi and NodeSlide contracts#219

Closed
HomenShum wants to merge 1 commit into
mainfrom
codex/nodekit-contract-reconcile
Closed

Reconcile NodeRoom's Pi and NodeSlide contracts#219
HomenShum wants to merge 1 commit into
mainfrom
codex/nodekit-contract-reconcile

Conversation

@HomenShum

@HomenShum HomenShum commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • declares NodeRoom's existing createPiAiAdapter integration as an adapter of the NodeAgent-owned nodeagent.provider-pi/v1 contract
  • records NodeRoom as a consumer of the merged NodeSlide deck and deck-patch contracts
  • changes no runtime, Convex function, UI, schema, package, or deployment behavior

Proof

  • NodeKit repo check: 11/11 checks passed against the coordinated registry
  • contract signatures: 4/4 classified
  • architecture exceptions: 0
  • git diff --check: passed
  • NodeRoom CI, scaffold check, ProofLoop gate, Vercel preview, and security checks: passed

Dependency status

Hosted node-platform / conformance fetches node-platform/main and is expected to remain red until the Pi/NodeSlide ownership updates in node-platform #4 land.

Boundaries

This is manifest-only contract reconciliation. No Convex deploy, production deploy, package publication, or runtime promotion was performed.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
noderoom Ready Ready Preview, Comment Jul 20, 2026 4:41am

Request Review

@github-actions

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20260720T044047Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20260720T044056354Z-33966e52_dirty.97507eb434a2e843/cascade-healthy.json
  • docs/eval/traces/credit/20260720T044056354Z-33966e52_dirty.97507eb434a2e843/delta-incomplete.json
  • docs/eval/traces/credit/20260720T044056354Z-33966e52_dirty.97507eb434a2e843/mapping-correct.json
  • docs/eval/traces/credit/20260720T044056354Z-33966e52_dirty.97507eb434a2e843/mapping-misbind.json
  • docs/eval/traces/credit/20260720T044056354Z-33966e52_dirty.97507eb434a2e843/summit-stressed.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20260720T044055902Z-33966e52_dirty.182b2b2cb3ded075/ladder_L7_resume_scripted.json
  • nodekit.yaml

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

@HomenShum

Copy link
Copy Markdown
Owner Author

Closing as superseded by the merged v0.2.2 mounted-consumer work in PRs #235 and #236. Current main retains the NodeAgent Pi and NodeSlide contract declarations, while exact-main conformance and the packed NodeSlide consumer are green; this older draft remains red on conformance and has no remaining acceptance role.

@HomenShum HomenShum closed this Jul 21, 2026
@HomenShum
HomenShum deleted the codex/nodekit-contract-reconcile branch July 21, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant