Skip to content

fix: harden CI workflows and resolve ESLint errors - #18

Merged
Shreyassp002 merged 3 commits into
HoomanBuilds:mainfrom
Shreyassp002:main
Apr 3, 2026
Merged

Shreyassp002 merged 3 commits into
HoomanBuilds:mainfrom
Shreyassp002:main

Conversation

@Shreyassp002

Copy link
Copy Markdown
Member

Summary

  • Harden Flash Review workflow — check out base ref instead of fork head to prevent untrusted code execution, fetch diff via GitHub API, build PR context safely via actions/github-script to prevent shell injection
  • Add missing PR triggers — both CI and Flash Review now trigger on reopened and ready_for_review events (previously missed draft→ready conversions and re-opened PRs)
  • Resolve all ESLint errors — downgrade no-explicit-any and ban-ts-comment to warnings, exclude documentation/ and inspiration/ from lint, fix 8 remaining errors (prefer-const, no-require-imports, react/no-unescaped-entities, React render issues)
  • Remove stale packageManager: yarn field from package.json (project uses npm)

Test plan

  • npm run lint — 0 errors (142 warnings)
  • npm run typecheck — 0 errors
  • npm test — 106 tests passed

@vercel

vercel Bot commented Apr 3, 2026

Copy link
Copy Markdown

@Shreyassp002 is attempting to deploy a commit to the Shreyas' projects Team on Vercel.

A member of the Team first needs to authorize it.

@Shreyassp002
Shreyassp002 merged commit 1f99a54 into HoomanBuilds:main Apr 3, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant